key name change 'buttons'->'button' #29600
Conversation
KeyError raised by `ipympl` resolved by this change. Restores interactive functionality in notebooks
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
There was a problem hiding this comment.
Thanks for the PR, however I believe the suggestion is not correct. There is indeed a buttons property on MouseEvents (https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/buttons), and from the masking above it's quite clear that this is meant.
The question should rather be: Why is the property not there? Please debug event['type'] to see which event you are processing. Also, can you please provide a minimal example so that we can inspect the underlying issue.
|
This was already reported in #29337, and fixed in matplotlib/ipympl#568, which was released in ipympl 0.9.5. Please update your packages. |
Yes, I saw others had similar issues that were resolved with |
|
@timhoffm Thanks for your interest and for re-framing the question. It appears to be a bug in VSCod(ium). Issue does not appear in vanilla jupyter lab server |
KeyError raised by
ipymplresolved by this change. Restores interactive functionality in notebooksPR summary
use of Ipympl in notebook raised KeyError. Changing
"buttons">>"button"resolves the issuePR checklist
(no change to source requiring new doc)
Example of error:
Example after commit: