Switch Tfm metrics to TrueType-compatible API. #29838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Mar 31, 2025
lib/matplotlib/dviread.pyi
Outdated
| def __init__(self, filename: str | os.PathLike) -> None: ... | ||
| def get_metrics(self, int) -> TexMetrics | None: ... |
There was a problem hiding this comment.
Suggested change
| def get_metrics(self, int) -> TexMetrics | None: ... | |
| def get_metrics(self, idx: int) -> TexMetrics | None: ... |
b09d728 to
3f2c7dd
Compare
timhoffm
approved these changes
Mar 31, 2025
dstansby
approved these changes
Mar 31, 2025
|
sure, done |
Instead of directly exposing widths, heights, depths dicts, provide a
get_metrics method to access a glyph's (tex) metrics. This change is in
preparation for {xe,lua}tex support, which would use an alternative
metrics-loading class (`TtfMetrics`) where it would be excessive to load
the metrics of all glyphs at once.
|
I'm a bit at loss as to how to placate mypy here, so if someone who actually uses typing could have a look, this would be very helpful :) |
|
Pushed a commit that fixes it locally. Look like this is a limitation in stubtests that does not correctly handle the |
|
Looks like it's related to (but not the same as) the fixed python/mypy#15749. Might be worth a minimal reproducer and a issue report upstream in mypy? |
|
I've got a minimal reproducer, will post an issue upstream |
|
Thanks :) |
|
thank you @dstansby ! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small preparatory PR for #29807 ({xe,lua}tex support).
Instead of directly exposing widths, heights, depths dicts, provide a get_metrics method to access a glyph's (tex) metrics. This change is in preparation for {xe,lua}tex support, which would use an alternative metrics-loading class (
TtfMetrics) where it would be excessive to load the metrics of all glyphs at once.PR summary
PR checklist