ci: cleanup: remove stale/outdated version range restrictions #29846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub Actions `tests.yml` workflow
…te references from GitHub Actions `tests.yml` workflow
dstansby
approved these changes
Apr 1, 2025
timhoffm
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Why is this change necessary?
This is primarily intended to aid comprehensibility and simplicity of the GitHub Actions
tests.ymlworkflow we're using.What problem does it solve?
The changeset here should make the file shorter and simpler.
What is the reasoning for this implementation?
The package version restrictions removed by this changeset no longer represent the latest version of each package that would be installed by default on each system during the workflows.
Strictly speaking, all subsequent/current versions of those packages could be removed or yanked from PyPI, but this seems unlikely.
There is some historic value in knowing that these versions were incompatible; I think that given that alternatives have been available and stable for some time (Nov 2023 for
pyqt6-verin 3c8b337, and May 2023 forpyside6-verin 6e05205), it may be OK to remove them now.Perhaps removing the templating/interpolation of the variables is controversial, too - arguably it could be necessary to restore range restrictions in future.
PR checklist
Resolves #29845.