The 'lines.markeredgecolor' now doesn't interfere on the color of errorbar caps #29895
Conversation
…olor To solve this, we needed to ensure that the caps would use the specified ecolor independently of the global mpl.rcParams['lines.markeredgecolor']. This was achieved by setting the marker edge color for the caps separately, rather than relying on the global configuration.
|
The default value of This is the correct fix. |
|
@useidemaisachola Thank you for this fix and the test! If you can clean up the linting/whitespace issues I think this can be merged straight away. |
|
@tacaswell ok, i can solve them! One question as this is my first PR - after i resolve the problems with the spaces i have to commit and open another PR? Or it's possible to still use this one? |
|
You should continue on your branch, and pushing it here will update this PR. |
|
@QuLogic Ok, thank you! |
|
@tacaswell I resolved the problem with the spaces! Now it's giving some kind of error with the version of python on windows... It is something that i have to change? |
|
@useidemaisachola that Azure Windows test can be flakey. The failure is not caused by your change. I have re-run it to see if we can be lucky the second time. |
|
so, now i have to resolve the conflits? |
Yes, but if you are not comfortable doing that we can handle it for you. It looks like you and and another recent PR have added new tests in the same place, so it's just a case of making sure we keep both. |
|
Already resolved the conflit but I guess i leaved an extra line at the end of the file or something like that, because it's failing one test... it's that? |
|
I took the liberty to remove the extra line at the end. Tests should pass now. |
| y = np.sin(x) | ||
| yerr = 0.1 | ||
| mpl.rcParams['lines.markeredgecolor'] = 'green' | ||
| ecolor = 'red' | ||
|
|
||
| fig, ax = plt.subplots() | ||
| errorbars = ax.errorbar(x, y, yerr=yerr, ecolor=ecolor, fmt='o', capsize=5) |
There was a problem hiding this comment.
| y = np.sin(x) | |
| yerr = 0.1 | |
| mpl.rcParams['lines.markeredgecolor'] = 'green' | |
| ecolor = 'red' | |
| fig, ax = plt.subplots() | |
| errorbars = ax.errorbar(x, y, yerr=yerr, ecolor=ecolor, fmt='o', capsize=5) | |
| mpl.rcParams['lines.markeredgecolor'] = 'green' | |
| ecolor = 'red' | |
| fig, ax = plt.subplots() | |
| errorbars = ax.errorbar(x, sin(x), yerr=0.1, ecolor=ecolor) |
- Inlining the only-once used parameters make the code more compact.
- The
fmtandcapsizeparameters don't have an influence. Leaving them out keeps the code more readable.
| y = np.sin(x) | ||
| yerr = 0.1 | ||
| mpl.rcParams['lines.markeredgecolor'] = 'green' | ||
|
|
||
| fig, ax = plt.subplots() | ||
| errorbars = ax.errorbar(x, y, yerr=yerr, fmt='o', capsize=5) |
There was a problem hiding this comment.
As above:
| y = np.sin(x) | |
| yerr = 0.1 | |
| mpl.rcParams['lines.markeredgecolor'] = 'green' | |
| fig, ax = plt.subplots() | |
| errorbars = ax.errorbar(x, y, yerr=yerr, fmt='o', capsize=5) | |
| mpl.rcParams['lines.markeredgecolor'] = 'green' | |
| fig, ax = plt.subplots() | |
| errorbars = ax.errorbar(x, np.sin(x), yerr=0.1) |
|
ok, thank you for the tips and the help! |
PR summary
-This change was necessary to resolve a bug: Fixes #29780
-Color of errorbar caps now it's not affected by 'lines.markeredgecolor'.
The initial issue arose when the caps of the error bars were unintentionally adopting the color red, which was set globally in mpl.rcParams under the 'lines.markeredgecolor' parameter. This global setting was being applied to all markers, including the caps of error bars, causing the caps to appear red even when that wasn't intended.
The root cause of the problem was that the marker edge color defined globally (mpl.rcParams['lines.markeredgecolor']) was being inherited by the caps as part of the error bar plot. This caused the color of the caps to match the global red color, even when only the error bars were supposed to be red (through the ecolor parameter).
To solve this, we needed to ensure that the caps would use the specified ecolor independently of the global mpl.rcParams['lines.markeredgecolor']. This was achieved by setting the marker edge color for the caps separately, rather than relying on the global configuration.
The files that suffered alterations were _axes.py and test_axes.py.
PR checklist