Check Axes/Figure import paths in boilerplate.py #29948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, if the Matplotlib installed in the current environment is not the same as the source tree
boilerplate.pyis from, theAxes/Figureclasses not taken from the correct source tree. This adds a guard to make sure this isn't the case.I have confirmed locally this prevents situations like those described in #29921
I can't think of a situation where one wants to deliberately generate
pyplot.pyfrom another source tree, but if there is manually specifying the other source tree as an argument toboilerplate.pyshould still work.Fixes #29921.