Backport PR #29796 on branch v3.10.x: ci: rotate soon-to-be-unsupported GitHub Actions ubuntu-20.04 runner out of roster #29949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Apr 22, 2025
.github/workflows/tests.yml
Outdated
Comment on lines
50
to
52
| - name-suffix: "(Minimum Versions)" | ||
| os: ubuntu-20.04 | ||
| python-version: '3.10' | ||
| os: ubuntu-22.04 | ||
| python-version: '3.11' |
There was a problem hiding this comment.
Minimum version should still test Python 3.10 for the 3.10 branch.
There was a problem hiding this comment.
Ooops. Do we still want the "normal" py310 on Ubuntu too?
There was a problem hiding this comment.
I think minver should be good enough to catch py310 incompatible code.
…b Actions ubuntu-20.04 runner out of roster (cherry picked from commit 0d11978)
3dfa981 to
704c239
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #29796. The conflict was because
mainhas some extra lines from #29171 right before the if-loop we're removing here.cherry picked from commit 0d11978