Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix typo: missing singlequote in unrecognized backend exception #29995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

NicoWeio
Copy link
Contributor

@NicoWeio NicoWeio commented May 1, 2025

PR summary

I hope I don't bother you with this tiny PR, but I'd like to have typos addressed eventually. :)
Using some crude RegEx searches (f"'\{.+" etc.), I made sure that no similar typos exist.

This is the code in question:

# Then check if it is a backend name.
try:
return self.resolve_backend(gui_or_backend)
except Exception: # KeyError ?
raise RuntimeError(
f"'{gui_or_backend} is not a recognised GUI loop or backend name")

I cross-checked the code style with similar messages in the same file:

if gui is None:
raise RuntimeError(f"'{backend}' is not a recognised backend name")

PR checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Copy link
Member

@WeatherGod WeatherGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure the test failures are unrelated to the changes that are here.

Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR - always helpful to have small fixes like this 😄

@dstansby dstansby added this to the v3.10.2 milestone May 1, 2025
@dstansby dstansby merged commit fa3e9da into matplotlib:main May 1, 2025
37 of 39 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request May 1, 2025
@NicoWeio NicoWeio deleted the missing-singlequote branch May 1, 2025 15:18
rcomer added a commit that referenced this pull request May 1, 2025
…995-on-v3.10.x

Backport PR #29995 on branch v3.10.x (Fix typo: missing singlequote in unrecognized backend exception)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants