Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Open
Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
2f366fa
Make arrow annotation arrowhead adjustable
Abitamim Dec 16, 2022
e8d7eb7
Add test - not sure if correct
Abitamim Dec 16, 2022
15bd7dc
Update tutorial
Abitamim Dec 16, 2022
4f57495
Fixed linting
Abitamim Dec 16, 2022
5c3fa60
Add reversed arrow-head support to larrow/rarrow
CharlieThornton33 Apr 17, 2025
8065549
Fix reversed arrow-head support for single arrows, handle edge cases
CharlieThornton33 Apr 20, 2025
0471e92
Add support for reversed arrow-heads and edge cases in DArrow, update…
CharlieThornton33 Apr 20, 2025
212cbc9
Update docstings, add what's new notes
CharlieThornton33 Apr 22, 2025
273a2fe
Fix typo in DArrow drawing code
CharlieThornton33 Apr 28, 2025
bf2d06b
Fixed padding inconsistency: reverted breaking API change
CharlieThornton33 Apr 28, 2025
0ea2f5a
Fix what's new example
CharlieThornton33 Apr 28, 2025
d7fd405
Create unit test for boxarrow head adjustment
CharlieThornton33 Apr 30, 2025
ff34b4b
Fixed linting
CharlieThornton33 Apr 30, 2025
d9b0b32
Update new test to use mpl20 figure style
CharlieThornton33 May 1, 2025
f3369c0
Changed padding for LArrow/RArrow to prevent text spilling out
CharlieThornton33 May 14, 2025
3913ef6
[skip ci] Fix spelling mistake in LArrow padding code
CharlieThornton33 May 14, 2025
63a4ba9
Remove 'poking-out' behaviour from reversed arrow-heads, add padding …
CharlieThornton33 Jun 19, 2025
7ed9fd1
Remove now-unneeded manual padding from What's New page
CharlieThornton33 Jun 19, 2025
d953aef
Remove test_boxarrow_adjustment
CharlieThornton33 Jun 19, 2025
d2105da
Prevent text overspill from DArrows using padding
CharlieThornton33 Jun 19, 2025
54147e6
Added test for arrow-head adjustments
CharlieThornton33 Jun 20, 2025
b5ba28e
Fix padding from straight-edges of reversed arrow heads, fix incorrec…
CharlieThornton33 Jul 5, 2025
976e54b
[skip ci] Fix indentation in galleries/users_explain/text/annotations.py
CharlieThornton33 Jul 9, 2025
a08c67b
[skip ci] Use python % operator rather than np.mod() to act on scalar…
CharlieThornton33 Jul 9, 2025
1dc613e
[skip ci] Fix padding for non-reversed small head-size arrows
CharlieThornton33 Jul 18, 2025
73d9532
[skip ci] Use += and -= abbreviations
CharlieThornton33 Jul 18, 2025
2b83aff
[skip ci] Change layout of vertex array for non-reversed LArrow head …
CharlieThornton33 Jul 18, 2025
e94a777
Improve clarity of DArrow padding code
CharlieThornton33 Jul 24, 2025
98d4bc4
Make What's New example simpler and more informative
CharlieThornton33 Jul 25, 2025
2ac0bff
Implement simplified padding rules
CharlieThornton33 Aug 9, 2025
a6e2abf
Fix padding for darrows
CharlieThornton33 Sep 9, 2025
f8ba249
Style padding code consistently between larrow and darrow
CharlieThornton33 Sep 9, 2025
7b4b3b1
[ci doc] Move what's new page to releases directory
CharlieThornton33 Sep 9, 2025
119a051
[skip ci] Make head-width validation clearer
CharlieThornton33 Sep 11, 2025
80d1c40
Move head-angle validation into constructor
CharlieThornton33 Sep 11, 2025
460306e
Remove references to 'text' for describing original box
CharlieThornton33 Sep 11, 2025
201e62c
[skip ci] Fix accidental paste into docstring
CharlieThornton33 Sep 11, 2025
94fa82d
Fix nomenclature (arrow tail -> arrow shaft)
CharlieThornton33 Sep 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions doc/users/next_whats_new/box_arrow_size_controls.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
Arrow-style sub-classes of ``BoxStyle`` support arrow head resizing
-------------------------------------------------------------------

The new *head_width* and *head_angle* parameters to
`.BoxStyle.LArrow`, `.BoxStyle.RArrow` and `.BoxStyle.DArrow` allow for adjustment
of the size and aspect ratio of the arrow heads used.

By using negative angles (or corresponding reflex angles) for *head_angle*, arrows
with 'backwards' heads may be created.

.. plot::
:include-source: true
:alt: Six arrow-shaped text boxes, all containing the text "Arrow". The top left arrow has a shorter head than default, while the top right arrow a longer head. The centre left double arrow has a "road-sign" shape (head as wide as the arrow tail), while the centre right arrow has a "backwards" head. The bottom left arrow has two heads which are larger than default, and the bottom right arrow has a head narrower than its tail.

import matplotlib.pyplot as plt

plt.text(0.2, 0.8, "Arrow", ha='center', size=16, bbox=dict(boxstyle="larrow, pad=0.3, head_angle=150"))
plt.text(0.7, 0.8, "Arrow", ha='center', size=16, bbox=dict(boxstyle="rarrow, pad=0.3, head_angle=30"))
plt.text(0.2, 0.2, "Arrow", ha='center', size=16, bbox=dict(boxstyle="darrow, pad=0.3, head_width=3"))
plt.text(0.7, 0.2, "Arrow", ha='center', size=16, bbox=dict(boxstyle="larrow, pad=0.3, head_width=0.5"))
plt.text(0.2, 0.5, "Arrow", ha='center', size=16, bbox=dict(boxstyle="darrow, pad=0.3, head_width=1, head_angle=60"))
plt.text(0.7, 0.5, "Arrow", ha='center', size=16, bbox=dict(boxstyle="rarrow, pad=0.3, head_width=2, head_angle=-90"))

plt.show()
10 changes: 5 additions & 5 deletions galleries/users_explain/text/annotations.py
Original file line number Diff line number Diff line change
Expand Up @@ -234,10 +234,10 @@
# Class Name Attrs
# ========== ============== ==========================
# Circle ``circle`` pad=0.3
# DArrow ``darrow`` pad=0.3
# DArrow ``darrow`` pad=0.3,head_width=1.5,head_angle=90
# Ellipse ``ellipse`` pad=0.3
# LArrow ``larrow`` pad=0.3
# RArrow ``rarrow`` pad=0.3
# LArrow ``larrow`` pad=0.3,head_width=1.5,head_angle=90
# RArrow ``rarrow`` pad=0.3,head_width=1.5,head_angle=90
# Round ``round`` pad=0.3,rounding_size=None
# Round4 ``round4`` pad=0.3,rounding_size=None
# Roundtooth ``roundtooth`` pad=0.3,tooth_size=None
Expand Down Expand Up @@ -303,8 +303,8 @@ def custom_box_style(x0, y0, width, height, mutation_size):
x0, y0 = x0 - pad, y0 - pad
x1, y1 = x0 + width, y0 + height
# return the new path
return Path([(x0, y0), (x1, y0), (x1, y1), (x0, y1),
(x0-pad, (y0+y1)/2), (x0, y0), (x0, y0)],
return Path([(x0, y0), (x1, y0), (x1, y1), (x0, y1), (x0, y1-pad),
(x0-pad, (y0+y1)/2), (x0, y0+pad), (x0, y0), (x0, y0)],
closed=True)

fig, ax = plt.subplots(figsize=(3, 3))
Expand Down
255 changes: 228 additions & 27 deletions lib/matplotlib/patches.py
Original file line number Diff line number Diff line change
Expand Up @@ -2508,33 +2508,133 @@ def __call__(self, x0, y0, width, height, mutation_size):
class LArrow:
"""A box in the shape of a left-pointing arrow."""

def __init__(self, pad=0.3):
def __init__(self, pad=0.3, head_width=1.5, head_angle=90.0):
"""
Parameters
----------
pad : float, default: 0.3
The amount of padding around the original box.
head_width : float, default: 1.5
The width of the arrow head, relative to that of the arrow body.
Only positive values are accepted.
head_angle : float, default: 90.0
The angle subtended by the tip of the arrow head, in degrees.
Only nonzero angles are accepted.
"""
self.pad = pad

if head_width < 0:
raise ValueError("The relative head width must be a positive number.")
else:
self.head_width = head_width

# Set arrow-head angle to within [0, 360 deg)
self.head_angle = head_angle % 360.

def __call__(self, x0, y0, width, height, mutation_size):
# padding
# scaled padding
pad = mutation_size * self.pad
# width and height with padding added.
# add padding to width and height
width, height = width + 2 * pad, height + 2 * pad
# boundary of the padded box
# boundary points of the padded box (arrow tail/body)
x0, y0 = x0 - pad, y0 - pad,
x1, y1 = x0 + width, y0 + height

# half-width and quarter-width of arrow tail
dx = (y1 - y0) / 2
dxx = dx / 2
x0 = x0 + pad / 1.4 # adjust by ~sqrt(2)

return Path._create_closed(
[(x0 + dxx, y0), (x1, y0), (x1, y1), (x0 + dxx, y1),
(x0 + dxx, y1 + dxx), (x0 - dx, y0 + dx),
(x0 + dxx, y0 - dxx), # arrow
(x0 + dxx, y0)])
# Pad text to position text and its padding margin exactly inside arrow tail
padding_offset = (0.5 * pad) + (0.25 * mutation_size)
x0 -= padding_offset

# The width adjustment is the distance that must be subtracted from
# y0 and added to y1 to reach the non-tip vertices of the head.
# The body width is 2dx.
# Subtracting 1 from the head width gives, in units of the body width,
# the total 'width' of arrow-head not within the body.
width_adjustment = (self.head_width - 1) * dx

if self.head_angle == 0:
# This would cause a division by zero ('infinitely long' arrow head)
raise ValueError("Head angle of zero is not valid.")
elif self.head_angle <= 180:
# Non-reversed arrow head (<---)

# tan(1/2 * angle subtended by arrow tip)
tan_half_angle = np.tan(self.head_angle * (math.pi / 360))

# The angle adjustment is the tip-to-body length of the arrow head.
# Each half of the arrow head is a right-angled triangle. Therefore,
# each half of the arrow head has, by trigonometry, tan(head_angle/2)=
# (dx+width_adjustment)/(dxx+angle_adjustment).
angle_adjustment = ((dx + width_adjustment) / tan_half_angle) - dxx

# If there is sufficient space available, shorten the arrow tail to push
# some of the text padding margin into the head
if self.head_width > 1 and pad * tan_half_angle < width_adjustment:
# Pad text into head
x0 += pad

return Path._create_closed([
(x0 + dxx, y0),
(x1, y0),
(x1, y1),
(x0 + dxx, y1),
(x0 + dxx, y1 + width_adjustment),
(x0 - angle_adjustment, y0 + dx),
(x0 + dxx, y0 - width_adjustment),
(x0 + dxx, y0)
])
else:
# Reversed arrow head (>---)

# tan(1/2 * angle subtended by arrow tip)
tan_half_angle = -np.tan(self.head_angle * (math.pi / 360))

if self.head_width <= 1:
# Rectangle; head entirely enclosed by body (don't count head
# 'poking' out of back of body)

return Path._create_closed([
(x0 + dxx, y0),
(x1, y0),
(x1, y1),
(x0 + dxx, y1),
(x0 + dxx, y0)
])


# Distance from end of arrow to points where slanted parts of head
# intercept arrow body
intercept_adjustment = width_adjustment / tan_half_angle

if intercept_adjustment < width:
# Some of arrow body is outside of head

return Path._create_closed([
(x0 + dxx, y0 - width_adjustment),
(x0 + dxx + intercept_adjustment, y0),
(x1, y0),
(x1, y1),
(x0 + dxx + intercept_adjustment, y1),
(x0 + dxx, y1 + width_adjustment),
(x0 + dxx, y0 - width_adjustment)
])
else:
# Trapezium-shaped reversed arrow (reversed triangle 'cut off' by
# end of body

# Vertical distance between top of text at end furthest from arrow
# head and corner of trapezium
vertical_offset = width_adjustment + ((x0 - x1) * tan_half_angle)

return Path._create_closed([
(x0 + dxx, y0 - width_adjustment),
(x1, y0 - vertical_offset),
(x1, y1 + vertical_offset),
(x0 + dxx, y1 + width_adjustment),
(x0 + dxx, y0 - width_adjustment)
])

@_register_style(_style_list)
class RArrow(LArrow):
Expand All @@ -2551,37 +2651,138 @@ class DArrow:
"""A box in the shape of a two-way arrow."""
# Modified from LArrow to add a right arrow to the bbox.

def __init__(self, pad=0.3):
def __init__(self, pad=0.3, head_width=1.5, head_angle=90.0):
"""
Parameters
----------
pad : float, default: 0.3
The amount of padding around the original box.
head_width : float, default: 1.5
The width of each arrow head, relative to that of the arrow body.
Only positive values are accepted.
head_angle : float, default: 90.0
The angle subtended by the tip of each arrow head, in degrees.
Only nonzero angles are accepted.
"""
self.pad = pad

if head_width < 0:
raise ValueError("The relative head width must be a positive number.")
else:
self.head_width = head_width

# Set arrow-head angle to within [0, 360 deg)
self.head_angle = head_angle % 360.

def __call__(self, x0, y0, width, height, mutation_size):
# padding
# scaled padding
pad = mutation_size * self.pad
# width and height with padding added.
# The width is padded by the arrows, so we don't need to pad it.
# add padding to height
height = height + 2 * pad
# boundary of the padded box
# boundary points of the padded box (arrow tail/body)
x0, y0 = x0 - pad, y0 - pad
x1, y1 = x0 + width, y0 + height

# half-width and quarter-width of arrow tail
dx = (y1 - y0) / 2
dxx = dx / 2
x0 = x0 + pad / 1.4 # adjust by ~sqrt(2)

return Path._create_closed([
(x0 + dxx, y0), (x1, y0), # bot-segment
(x1, y0 - dxx), (x1 + dx + dxx, y0 + dx),
(x1, y1 + dxx), # right-arrow
(x1, y1), (x0 + dxx, y1), # top-segment
(x0 + dxx, y1 + dxx), (x0 - dx, y0 + dx),
(x0 + dxx, y0 - dxx), # left-arrow
(x0 + dxx, y0)])

# Pad text
padding_offset = (0.5 * pad) + (0.25 * mutation_size)
x0 -= padding_offset
x1 += 2 * pad

# The width adjustment is the distance that must be subtracted from
# y0 and added to y1 to reach the non-tip vertices of the head.
# The body width is 2dx.
# Subtracting 1 from the head width gives, in units of the body width,
# the total 'width' of arrow-head not within the body.
width_adjustment = (self.head_width - 1) * dx

if self.head_angle == 0:
# This would cause a division by zero ('infinitely long' arrow head)
raise ValueError("Head angle of zero is not valid.")
elif self.head_angle <= 180:
# Non-reversed arrow heads (<--->)

# tan(1/2 * angle subtended by arrow tip)
tan_half_angle = np.tan(self.head_angle * (math.pi / 360))

# The angle adjustment is the tip-to-body length of the arrow head.
# Each half of the arrow head is a right-angled triangle. Therefore,
# each half of the arrow head has, by trigonometry, tan(head_angle/2)=
# (dx+width_adjustment)/(dxx+angle_adjustment).
angle_adjustment = ((dx + width_adjustment) / tan_half_angle) - dxx

# If there is sufficient space available, shorten the arrow tail to push
# some of the text padding margin into the heads
if self.head_width > 1 and pad * tan_half_angle < width_adjustment:
# Pad text into heads
x0 += pad
x1 -= pad

return Path._create_closed([
(x0 + dxx, y0),
(x1, y0),
(x1, y0 - width_adjustment),
(x1 + dxx + angle_adjustment, y0 + dx),
(x1, y1 + width_adjustment),
(x1, y1),
(x0 + dxx, y1),
(x0 + dxx, y1 + width_adjustment),
(x0 - angle_adjustment, y0 + dx),
(x0 + dxx, y0 - width_adjustment),
(x0 + dxx, y0)
])
else:
# Reversed arrow heads (>---<)

# tan(1/2 * angle subtended by arrow tip)
tan_half_angle = -np.tan(self.head_angle * (math.pi / 360))

if self.head_width <= 1:
# Rectangle; heads entirely enclosed by body

return Path._create_closed([
(x0 + dxx, y0),
(x1, y0),
(x1, y1),
(x0 + dxx, y1),
(x0 + dxx, y0)
])

# Distance from end of arrow to points where slanted parts of head
# intercept arrow body
intercept_adjustment = width_adjustment / tan_half_angle

if (2 * intercept_adjustment) < width:
# Some of arrow body is outside of heads

return Path._create_closed([
(x0 + dxx, y0 - width_adjustment),
(x0 + dxx + intercept_adjustment, y0),
(x1 - intercept_adjustment, y0),
(x1, y0 - width_adjustment),
(x1, y1 + width_adjustment),
(x1 - intercept_adjustment, y1),
(x0 + dxx + intercept_adjustment, y1),
(x0 + dxx, y1 + width_adjustment),
(x0 + dxx, y0 - width_adjustment)
])
else:
# Draw overlapping arrow heads

# y-offset inwards of central points
centre_offset = (width * tan_half_angle) / 2

return Path._create_closed([
(x0 + dxx, y0 - width_adjustment),
((x0 + x1 + dxx) / 2, y0 - width_adjustment + centre_offset),
(x1, y0 - width_adjustment),
(x1, y1 + width_adjustment),
((x0 + x1 + dxx) / 2, y1 + width_adjustment - centre_offset),
(x0 + dxx, y1 + width_adjustment),
(x0 + dxx, y0 - width_adjustment)
])

@_register_style(_style_list)
class Round:
Expand Down
12 changes: 10 additions & 2 deletions lib/matplotlib/patches.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,11 @@ class BoxStyle(_Style):

class LArrow(BoxStyle):
pad: float
def __init__(self, pad: float = ...) -> None: ...
head_width: float
head_angle: float
Comment on lines +381 to +382
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these appear to be new public attributes, the tests should also check that modifying them after creation is working correctly.

def __init__(
self, pad: float = ..., head_width: float = ..., head_angle: float = ...
) -> None: ...
def __call__(
self,
x0: float,
Expand All @@ -400,7 +404,11 @@ class BoxStyle(_Style):

class DArrow(BoxStyle):
pad: float
def __init__(self, pad: float = ...) -> None: ...
head_width: float
head_angle: float
def __init__(
self, pad: float = ..., head_width: float = ..., head_angle: float = ...
) -> None: ...
def __call__(
self,
x0: float,
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading