Remove apply_theta_transforms argument #30004
Open
+28
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
May 6, 2025
Comment on lines
218
to
220
| return PolarAxes.PolarTransform( | ||
| self._axis, self._use_rmin, | ||
| apply_theta_transforms=self._apply_theta_transforms | ||
| ) |
There was a problem hiding this comment.
Can shrink:
Suggested change
| return PolarAxes.PolarTransform( | |
| self._axis, self._use_rmin, | |
| apply_theta_transforms=self._apply_theta_transforms | |
| ) | |
| return PolarAxes.PolarTransform(self._axis, self._use_rmin) |
Comment on lines
+1556
to
1558
| tr = PolarAxes.PolarTransform() | ||
| trans = tr + self.axes.transData | ||
| return trans |
There was a problem hiding this comment.
Maybe squash:
Suggested change
| tr = PolarAxes.PolarTransform() | |
| trans = tr + self.axes.transData | |
| return trans | |
| return PolarAxes.PolarTransform() + self.axes.transData |
Comment on lines
85
to
+86
| tr = (Affine2D().scale(np.pi / 180., 1.) + | ||
| PolarAxes.PolarTransform(apply_theta_transforms=False)) | ||
| PolarAxes.PolarTransform()) |
There was a problem hiding this comment.
Suggested change
| tr = (Affine2D().scale(np.pi / 180., 1.) + | |
| PolarAxes.PolarTransform(apply_theta_transforms=False)) | |
| PolarAxes.PolarTransform()) | |
| tr = Affine2D().scale(np.pi / 180, 1) + PolarAxes.PolarTransform() |
Comment on lines
148
to
+149
| tr = (Affine2D().scale(np.pi / 180., 1.) + | ||
| PolarAxes.PolarTransform(apply_theta_transforms=False)) | ||
| PolarAxes.PolarTransform()) |
There was a problem hiding this comment.
Suggested change
| tr = (Affine2D().scale(np.pi / 180., 1.) + | |
| PolarAxes.PolarTransform(apply_theta_transforms=False)) | |
| PolarAxes.PolarTransform()) | |
| tr = Affine2D().scale(np.pi / 180, 1) + PolarAxes.PolarTransform() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the deprecation that was introduced in #24834.