-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Bug Fix For "matplotlib eventplot not shows all the binary data for big number of events" - Draft PR #30053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bug Fix For "matplotlib eventplot not shows all the binary data for big number of events" - Draft PR #30053
Conversation
Hi @ebubekir-pulat I see you now have three draft PRs open. Do you need some help from us to get them ready for review? In general draft PRs tend to be ignored and assumed "work in progress" unless you tell us otherwise. Thanks for your contributions! |
Thank you @rcomer for the response. Yes, I would like some advice on how to improve my pull requests to get them ready for merging. What should I write in my pull requests to clearly show I would like feedback, criticism etc? |
@ebubekir-pulat we have some guidelines here to work through, but as it says, it doesn't have to be perfect. If you are stuck on something specific, do ask. If not, mark the PR ready for review when you have got it as ready as you can. |
…at/SPI_GROUP6_matplotlib into bug-fix-issue-20243
** DRAFT PULL REQUEST **
closes #20243
This PR is a fix to the bug from Issue 20243. The bug concerns events being missing in graphs outputted by eventplot, when there is insufficient space for all events, for example when linelengths=1 and there is small screen space, and over 500 events to plot.
The fix involves a simple check to whether the number of events exceeds 200, and if the snap kwargs has not been set explicitly by the eventplot caller, and if so, turns off snapping, sets 'antialiaseds' to True, and outputs a warning letting them know snapping has been turned off due to high number of events, but they can override by manually setting snapping to True. Below (Figure 1) is a screenshot showing how the fix should work.
Figure 1

I believe this is the appropriate fix for this issue, as Path Simplification does not appear to be the source of the bug, as shown below, where the code in Figure 2 was run, with a print statement in src/path_converters.h, after the initial if-statement in the PathSimplifier Class' vertex function, on the main branch, as shown in Figure 3. Despite the print statement, no prints were outputted into the terminal when running the code in Figure 2, as shown in the terminal output in Figure 4. This suggests that Path Simplification is not involved in the bug in #20243.
Figure 2

Figure 3

Figure 4
