Close star polygons #30069
Merged
Close star polygons #30069
+147
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
approved these changes
May 18, 2025
Perhaps the clip_path test is enough. I was planning to make a zoomed-in test to really show the change, but of course the hatch markers are in display coordinates so you have to zoom in the file viewer and not when producing the image. |
When '*' hatching was used and you zoomed in (especially in vector formats), the top of the star was not joined quite right. Using closepoly as the last operation fixes this.
rcomer
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When '*' hatching was used and you zoomed in (especially in vector formats), the top of the star was not joined quite right. Using closepoly as the last operation fixes this.
Before:
After:
See also #29392 which fills the stars.