Fix label_outer in the presence of colorbars. #30098
Merged
+25
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
May 23, 2025
jklymak
reviewed
May 23, 2025
| f, axs = plt.subplots(2, 2, sharex=True, sharey=True) | ||
| @pytest.mark.parametrize('with_colorbar', [True, False]) | ||
| def test_label_outer(remove_ticks, with_colorbar): | ||
| fig, axs = plt.subplots(2, 2, sharex=True, sharey=True) |
There was a problem hiding this comment.
Can this get tested with layout=constrained as well?
There was a problem hiding this comment.
done (but the flagging above with _is_colorbar_gridspec still needs to be done).
add6bbf to
045db0f
Compare
The subgridspec to be considered should be the one containing both the axes and the colorbar, not the sub-subgridspec of just the axes.
timhoffm
approved these changes
Jun 30, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 30, 2025
oscargus
pushed a commit
that referenced
this pull request
Jun 30, 2025
…0228) Co-authored-by: Tim Hoffmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subgridspec to be considered should be the one containing both the axes and the colorbar, not the sub-subgridspec of just the axes.
Closes #27305 (using #27305 (comment) and a test).
PR summary
PR checklist