Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix figure legend when drawing stackplots #30186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix figure legend when drawing stackplots #30186

wants to merge 1 commit into from
+0 −1

Conversation

dstansby
Copy link
Member

PR summary

Fixes #30158 - as suggested in #30158 (comment), two calls were trying to set the figure, and I think one of them doesn't need to.

PR checklist

@QuLogic
Copy link
Member

QuLogic commented Jun 19, 2025

Yes, I believe this is correct; HandlerBase.update_prop will set the correct figure (via Legend._set_artist_props), HandlerPolyCollection._update_prop exists to do the class-specific work of pulling the properties from the first artist in a collection and doesn't need to set the figure.

This could do with a test though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: needs tests topic: legend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Stackplot in SubFigure raises when drawing Legend
2 participants
@dstansby @QuLogic