Fix #26143: Document dynamic resizing in MathTextParser #30192
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thanks for the willingness to contribute. I’m afraid you’ve misread the issue. You need to actually implement the resizing, not claim that it exists. Also, from the way PR content and message are written, I have the impression that you’ve used GenAI. If that’s the case, please make sure you really understand what you are doing https://matplotlib.org/devdocs/devel/contribute.html#restrictions-on-generative-ai-usage. As is, this contribution is not helpful and only creates additional work for core developers. |
|
Thank you for your feedback. I now understand that I made a mistake. I thought the issue was only about writing documentation, so I added a note. I did not know I was supposed to write code for the resizing feature. I want to say that I did not fully use AI to make the PR. I learned by reading the code and asking seniors for help. I only used AI to fix grammar in my pull request message. I have understood my mistake, and I really want to try again. I want to fix the issue in the correct way by writing the actual code for resizing. I am still learning, but I am serious about open source and I want to do better. If it’s okay, can I try again? Thank you again for your time. |
|
Sure, you are welcome to try again. I'll reopen here and you can force-push your new solution over the first attempt. |
|
Thank you for giving me another chance. I understood the issue now. I will fix it correctly and push the updated code soon. |
|
Hi , All tests have passed successfully. Only the AppVeyor build is still pending. Please let me know if I need to do anything else. Thank you for giving me a chance to contribute! |
|
Hi, |
Summary
Fixes issue #26143.
This change improves the
MathTextParserclass inmathtext.py.Before, the symbol cache was not cleared when the backend or font changed, so it sometimes used incorrect symbols.
Now, I clear the cache when either the backend or font is different. This fixes the issue and keeps the symbols accurate.