Update type hints to fix #30160 #30193
Closed
+276
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create get_signature method - Create AXES_GETTER_SETTER_TEMPLATE - Create call_param method on generate_function
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
QuLogic
reviewed
Jun 20, 2025
|
This PR does a lot of independent things. Splitting up into individual PRs for the different topics would make reviewing simpler. There are at least the three "This PR ..." blocks if not the five top-level bullet points. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This PR update the
tools/boilerplate.pyforxlimylimThis PR update
lib/matplotlib/pyplot.py*args, **kwargswith the real signature for the following methods:savefigset_loglevelsubplotshowThis PR add tests for checking the pyplot signature
test_setloglevel_signature:plt.set_loglevelmpl.set_logleveltest_polar_signature:plt.polarAxes.plotPR checklist
Additional comments
Not done on this PR (because not directly linked to the Issue) but why not replace level: str with level: Literal[...]