Thanks to visit codestin.com
Credit goes to github.com

Skip to content

agg: Replace facepair_t with std::optional #30196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

agg: Replace facepair_t with std::optional #30196

wants to merge 1 commit into from
+25 −22

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jun 20, 2025 •
edited
Loading

PR summary

This type seems to cover the intent more clearly than std::pair<bool, ...>.

PR checklist

@QuLogic QuLogic added this to the v3.11.0 milestone Jun 20, 2025
@QuLogic QuLogic added the CI: Run cibuildwheel Run wheel building tests on a PR label Jun 20, 2025
@github-actions github-actions bot added backend: agg and removed CI: Run cibuildwheel Run wheel building tests on a PR labels Jun 20, 2025
@QuLogic
Copy link
Member Author

QuLogic commented Jun 20, 2025

Our macOS deployment target is too old to like std::optional::value(), so I've changed it to std::optional::operator*.

@QuLogic QuLogic added the CI: Run cibuildwheel Run wheel building tests on a PR label Jun 20, 2025
timhoffm
timhoffm reviewed Jun 21, 2025
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would decide on one of the APIs

  • use pointer-like syntax if (face), *face
  • use explicit syntax if (face.has_value()), face.value()

but not mix them.

@QuLogic
Replace facepair_t with std::optional
bbff84c 
This type seems to cover the intent more clearly than `std::pair<bool,
...>`.
@github-actions github-actions bot removed the CI: Run cibuildwheel Run wheel building tests on a PR label Jun 21, 2025
@QuLogic
Copy link
Member Author

QuLogic commented Jun 21, 2025

Well, we can't do face.value(), so it'll have to be the former.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm left review comments

@jkseppan jkseppan jkseppan approved these changes

Assignees
No one assigned
Labels
backend: agg
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @jkseppan @timhoffm