Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix unable to find Freefont on Ubuntu 14.04 #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix unable to find Freefont on Ubuntu 14.04 #3032

wants to merge 1 commit into from

Conversation

maciejkula
Copy link

Ensure that .add_flags is called for Freefont when building from source.

Otherwise we only look in ['/usr/local/include', '/usr/include', '.'], and none of these contain Freefont on Ubuntu 14.04.

Solves #3029.

@tacaswell tacaswell added this to the v1.4.0 milestone May 17, 2014
@tacaswell tacaswell mentioned this pull request May 17, 2014
Closed
@tacaswell
Copy link
Member

This is almost identical to #3032.

@maciejkula
Copy link
Author

You mean #3067 is almost identical to this? :)

tacaswell
tacaswell reviewed May 18, 2014
View reviewed changes
setupext.py
@@ -906,6 +906,14 @@ def check(self):
'freetype2', 'ft2build.h',
min_version='2.4', version=version)

def get_extension(self):
ext = make_extension('test', [])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this string 'test'?

@tacaswell
Copy link
Member

Details.....

@maciejkula
Copy link
Author

For the same reason why

ext = Extension('test', [])
ext.include_dirs.append(numpy.get_include())

has test in it --- no idea.

Jesting aside, I'm happy to close this in favour of #3067, looks better formatted anyway (and passes tests?).

@maciejkula maciejkula closed this May 19, 2014
@tacaswell
Copy link
Member

The other difference is that this PR calls pkg_config.setup_extension(ext, 'freetype2') which the other does not.

I would rather keep both open for now and close one once it is sorted out.

@tacaswell tacaswell reopened this May 19, 2014
@razius
Copy link
Contributor

razius commented May 24, 2014

Ah sorry, I didn't noticed that there was already a fix for the problem.

@tacaswell
Copy link
Member

@razius Could you explain the differences between the two patches?

@razius
Copy link
Contributor

razius commented May 29, 2014

Apart from some syntax differences this also calls the setup_extension method but that is also called by the add_flags method which is invoked afterwards so it ends up being called twice.

https://github.com/matplotlib/matplotlib/blob/master/setupext.py#L910

@tacaswell
Copy link
Member

Closed as #3067 is merged.

@tacaswell tacaswell closed this May 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@maciejkula @tacaswell @razius @QuLogic