Add datetime test for ax.violin #30384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1a6a11a to
3fa749b
Compare
Thanks for the example - I've opened an issue, and mentioned it in the test I added. |
timhoffm
approved these changes
Aug 12, 2025
QuLogic
reviewed
Aug 12, 2025
Co-authored-by: Elliott Sales de Andrade <[email protected]>
QuLogic
approved these changes
Aug 26, 2025
This was referenced Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Part of #26864.
violin()seems to work fine, but thepositionsargument does not work at the moment - it's not immediately obvious to me if it should, so I left a TODO ending with a question mark in the test.Replaces #27486.
PR checklist