-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Update Colorizer/ColorizingArtist to work with MultiNorm #30511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
77bc51a
to
9044189
Compare
9b9aaf3
to
525314e
Compare
Thank you for the feedback @QuLogic and apologies for my sloppy mistakes :) |
improved testing for colorizer+multinorm Apply suggestions from code review Co-authored-by: Elliott Sales de Andrade <[email protected]> updates based on feedback from @QuLogic
525314e
to
23fb63c
Compare
eb37db8
to
d5c43e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned on the call, I think this looks okay from a low-level point-of-view, but I am at this point uncertain as to the high-level status. I hope someone more familiar with the current state can confirm.
PS, @trygvrad if you have some time to pop in to the call, it would be good to just re-iterate the current state succinctly, as I'm not sure everyone is up-to-speed right now.
This PR continues the work of #28658 and #28454, #29876, aiming to close #14168. (Feature request: Bivariate colormapping)
This PR allows Colorizer and ColorizingArtist to work with
MultiNorm
andBivarColormap
andMultivarColormap
i.e. this PR will allow:
Features not included in this PR:
axes.imshow(...)
,axes.pcolor(...), and
axes.pcolormesh(...)`PR checklist