gtk: Add more explicit version requirements #30533
Open
+48
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, this doesn't explicitly do |
|
What about try:
gi.require_version("GioUnix", "2.0")
except ValueError:
# GioUnix is not available on this platform, which is fine
passI tried it in #30535 |
This adds requirements for all of Gdk/GdkPixbuf/Gio/GLib/GObject before using them, as we do for Gtk. Fixes matplotlib#30525
This test has been an expected failure since it was created, and in that time, `gtk_test_widget_send_key` was never made to work, nor was a replacement found. In GTK4, that API doesn't exist either.
For example, GTK3 and GTK4 conflict, and which one is tested depends on which one loads first. Running in a subprocess ensures that both work, but we only do that for backends as adding ~100 more subprocesses is overkill.
8a720cb to
93a5b91
Compare
|
Sorry I was going down the issue list in order and merged #30535 before I got to this one. |
|
That is okay; this has turned into more of a cleanup on the tests a bit than fully fixing the original issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This adds requirements for all of Gdk/GdkPixbuf/Gio/GLib/GObject before using them, as we do for Gtk.
Note, Gdk is bunded with Gtk, so it's the only one that changes versions depending on backend.
Fixes #30525
PR checklist