Improving error message for width and position type mismatch in violinplot #30545
+110
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Sep 11, 2025
Comment on lines
+9053
to
+9054
| if any(isinstance(p, (datetime.datetime, datetime.date)) | ||
| for p in positions): |
There was a problem hiding this comment.
Isn't it enough to check the first position? I think mixed positions are not allowed anyway. Also, do we need to handle np.datetime64 arrays?
| # widths must be timedelta-like. | ||
| if any(isinstance(p, (datetime.datetime, datetime.date)) | ||
| for p in positions): | ||
| _widths = widths if not np.isscalar(widths) else [widths] * N |
There was a problem hiding this comment.
This is only used to do the instance check. We don't need to do this N times on the the same instance.
Suggested change
| _widths = widths if not np.isscalar(widths) else [widths] * N | |
| _widths = widths if not np.isscalar(widths) else [widths] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to close [ENH]: Support using datetimes as positions argument to violin(...) #30417
It should be possible to set the position of a violin plot to be a datetime. Currently, an attempt to do this results in this error message: TypeError: unsupported operand type(s) for +: 'float' and 'datetime.datetime'
The error stems from trying to perform operations between float and datetime if datetime was provided as position arguments.
The proposed solution improves the error message to be:
"If positions are datetime/date values, pass widths as datetime.timedelta (e.g., datetime.timedelta(days=10)) or numpy.timedelta64.unit tests are in tests\test_violinplot_datetime.py
I had opened another PR 30508, but messed up the commits while making changes. I am making this one after reading the suggestion here: #30508 (comment) by @rcomer . This change updates the error message instead of converting the position and width