fix argument checks in axis/base.margins #3078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If keyword arguments where used, like mentioned in the documentation, the code would fail as if more than two parameters where given (since len(args) would be 0 -> != 1/2)
| @@ -3109,6 +3109,25 @@ def test_pie_ccw_true(): | |||
| # Set aspect ratio to be equal so that pie is drawn as a circle. | |||
| plt.axis('equal') | |||
|
|
|||
| @image_comparison(baseline_images=['margins_1', 'margins_1_05_arg', 'margins_1_05_kwarg'], extensions=['png']) | |||
There was a problem hiding this comment.
We don't need to create images for these tests - the actual testing is being done in the assertions. As a result, we should just be able to remove this decorator, and replace it with the cleanup one.
|
You are right, it seems I was a little bit too eager there^^, fixed |
| @@ -3109,6 +3109,24 @@ def test_pie_ccw_true(): | |||
| # Set aspect ratio to be equal so that pie is drawn as a circle. | |||
| plt.axis('equal') | |||
|
|
|||
| def test_margins(): | |||
There was a problem hiding this comment.
This needs a @cleanup to make sure we don't like figures in the tests.
pelson
added a commit
that referenced
this pull request
May 28, 2014
fix argument checks in axis/base.margins
|
Thanks @andreasWallner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried this code today when guessing parameter names:
Which should set the axis margins (according to the function docstring) but throws this error
After looking at the code it seems to me that the keyword parameters where simply forgotten in the checks.
This patch fixes this problem and provides test cases for all call variants of margins.
PS: I hope I did not add too many pictures for such a simple test, but I did not find a way to check for the same picture twice (margins_1_05_arg.png & margins_1_05_kwarg.png).