Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: Update triage team nomination instructions#31089

Open
melissawm wants to merge 6 commits intomatplotlib:mainfrom
melissawm:update-triage-docs
Open

DOC: Update triage team nomination instructions#31089
melissawm wants to merge 6 commits intomatplotlib:mainfrom
melissawm:update-triage-docs

Conversation

@melissawm
Copy link
Copy Markdown
Member

PR summary

Updates triage team nomination instructions section with Discourse link and some clarification on what potential candidates can do before they are nominated.

PR checklist

@github-actions github-actions Bot added the Documentation: devdocs files in doc/devel label Feb 5, 2026
Copy link
Copy Markdown
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

Comment thread doc/devel/triage.rst Outdated
Comment on lines +209 to +213
1. Correctly triage 2-3 issues or review 2-3 pull requests. Actually labeling or
closing issues and PRs require triage permissions, but you can verify with
comments if issues have enough information or are still valid, and suggest
changes to PRs, particularly if you can help contributors solve CI check
failures.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of information here, so wonder if this would work better by being integrated into our how to triage instructions, with a link to those instructions?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will rework!

@melissawm
Copy link
Copy Markdown
Member Author

melissawm commented Feb 5, 2026

Looks like the failure is a separate issue:

/home/circleci/project/doc/devel/development_setup.rst:291: WARNING: 'envvar' reference target not found: MESONPY_EDITABLE_VERBOSE [ref.envvar]

@melissawm
Copy link
Copy Markdown
Member Author

I decided to review the entire doc and try a new organization, grouping together the issue-related instructions and the PR instructions. Also added notes about the "good first issue" pulling from the language recently added to the contributing guide, and added some links to the labels on github for convenience.

@melissawm
Copy link
Copy Markdown
Member Author

I am trying to figure out how to add an external reference label that uses a colon in rst 🙃

Comment thread doc/devel/triage.rst
@melissawm melissawm force-pushed the update-triage-docs branch from f542002 to 6775b2d Compare April 9, 2026 19:01
Comment thread doc/devel/triage.rst Outdated
Comment thread doc/devel/triage.rst Outdated
Comment thread doc/devel/triage.rst Outdated
Copy link
Copy Markdown
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone can dismiss when this is addressed, just staff is a completly different team on discourse.

Also thanks, this is great!

Comment thread doc/devel/triage.rst Outdated
Comment thread doc/devel/triage.rst
Comment on lines +242 to +243
the triage team by nominating them through the private "Triage team nominations"
category on `Discourse <https://discourse.matplotlib.org>`__ (Note that only
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the confirmation (this nomination was approved) step?/next part of the process, or is that a follow up PR?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a Steering Council action but I wonder if we should add a timeline for a response?

Copy link
Copy Markdown
Member

@story645 story645 Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it has to be since @QuLogic and @ksunden can add people, but agree there should be a timeline. And a confirmation flag like closing the thread?

Comment thread doc/devel/triage.rst Outdated
Comment thread doc/devel/triage.rst Outdated
@story645
Copy link
Copy Markdown
Member

@melissawm should I merge or wait on "next steps" discussion?

@melissawm
Copy link
Copy Markdown
Member Author

Let's discuss in the meeting re: next steps. Thanks!

Comment thread doc/devel/triage.rst
Comment on lines +243 to +246
category on `Discourse <https://discourse.matplotlib.org>`__ (Note that only
``@maintainers`` and ``@triage`` members can see this category). The nomination
will then be confirmed by the Steering Council and the user, if accepted, will
be added to the triage team on GitHub.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
category on `Discourse <https://discourse.matplotlib.org>`__ (Note that only
``@maintainers`` and ``@triage`` members can see this category). The nomination
will then be confirmed by the Steering Council and the user, if accepted, will
be added to the triage team on GitHub.
category on `Discourse <https://discourse.matplotlib.org>`__ (Note that only
``@maintainers`` and ``@triage`` members can see this category).
If no objections are raised in the nomination topic after one week, a member with the `owner` role on GitHub will send an invitation email to the nominee following a template. Once the nominee responds affirmatively, they will add the nominee to the Triage group on GitHub, and close the Discourse thread with a confirmation that the nomination was accepted.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation: devdocs files in doc/devel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants