Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement conditional autoscaling for Collections using Artist autoscale flag #31274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Archiljain wants to merge 8 commits into
base: main
Choose a base branch
from
+48 −26
Open

Implement conditional autoscaling for Collections using Artist autoscale flag #31274

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
99fee32
Use Artist autoscale participation flag for conditional autoscaling o…
Archiljain Mar 11, 2026
e8d3bd3
solving merge head
Archiljain Mar 11, 2026
be151e1
fixing requested reviews
Archiljain Mar 11, 2026
3e6c3c0
Refactor add_collection autoscale handling into _update_collection_li…
Archiljain Mar 13, 2026
9b9a23e
Added docstring and refine _update_collection_limits
Archiljain Mar 14, 2026
50f4247
Align autoscale handling with existing design by removing autolim fro…
Archiljain Mar 23, 2026
424c780
Fix autoscale logic: ensure _request_autoscale_view only runs when au…
Archiljain Mar 25, 2026
eb2ebe8
Fix collection autoscale integration in relim and align with autoscal…
Archiljain Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/matplotlib/axes/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import matplotlib.text as mtext
import matplotlib.ticker as mticker
import matplotlib.transforms as mtransforms
import matplotlib.collections as mcollections
Copy link
Copy Markdown
Member

@QuLogic QuLogic Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

collections is already imported above.


_log = logging.getLogger(__name__)

Expand Down Expand Up @@ -1133,6 +1134,11 @@ def _update_transScale(self):
mtransforms.blended_transform_factory(
self.xaxis.get_transform(), self.yaxis.get_transform()))

def _update_collection_limits(self, collection):
offsets = collection.get_offsets()
if offsets is not None and len(offsets):
self.update_datalim(offsets)
Copy link
Copy Markdown
Member

@QuLogic QuLogic Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very wrong indent, I don't know why linting isn't complaining.

This method also appears to be inserted into a completely random spot; I'd expect it to be located somewhere that parallels the other _update* methods.


Comment thread
timhoffm marked this conversation as resolved.
Outdated
def get_position(self, original=False):
"""
Return the position of the Axes within the figure as a `.Bbox`.
Expand Down Expand Up @@ -2421,6 +2427,7 @@ def add_collection(self, collection, autolim=True):
self._request_autoscale_view()

self.stale = True
collection._set_in_autoscale(autolim)
return collection

def add_image(self, image):
Expand Down Expand Up @@ -2649,6 +2656,8 @@ def relim(self, visible_only=False):
self._update_patch_limits(artist)
elif isinstance(artist, mimage.AxesImage):
self._update_image_limits(artist)
elif isinstance(artist, mcollections.Collection):
self._update_collection_limits(artist)

def update_datalim(self, xys, updatex=True, updatey=True):
"""
Expand Down
24 changes: 24 additions & 0 deletions lib/matplotlib/tests/test_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10189,3 +10189,27 @@ def test_errorbar_uses_rcparams():
assert_allclose([cap.get_markeredgewidth() for cap in caplines], 2.5)
for barcol in barlinecols:
assert_allclose(barcol.get_linewidths(), 1.75)


def test_relim_updates_scatter_offsets():
import numpy as np
import matplotlib.pyplot as plt

Copy link
Copy Markdown
Member

@QuLogic QuLogic Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary imports.

fig, ax = plt.subplots()

xs = np.linspace(0, 10, 100)
ys = np.sin(xs)
scatter = ax.scatter(xs, ys)

# Shift scatter upward
new_ys = np.sin(xs) + 5
scatter.set_offsets(np.column_stack((xs, new_ys)))

ax.relim()
ax.autoscale_view()

ymin, ymax = ax.get_ylim()

# New limits should reflect shifted data
assert ymin > 3
assert ymax > 5
Loading