-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Fix #21409: Make twin axes inherit parent position #31353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d9ef7af
88d4ec5
a5435b5
ce749b4
5876d06
e8df9e5
c2a343c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4657,6 +4657,20 @@ def _make_twin_axes(self, *args, **kwargs): | |
| twin.set_zorder(self.zorder) | ||
|
|
||
| self._twinned_axes.join(self, twin) | ||
|
|
||
| # If the parent Axes has been manually positioned (set_position() sets | ||
| # in_layout=False), the SubplotSpec-based add_subplot(...) path ignores | ||
| # that manual position when creating a twin. In that case, explicitly | ||
| # copy both the original and active positions to the twin so they start | ||
| # aligned. | ||
| # | ||
| # For layout-managed Axes (in_layout=True), we keep the existing | ||
| # SubplotSpec-driven behavior, so layout engines such as tight_layout | ||
| # and constrained_layout continue to control positioning. | ||
| if not self.get_in_layout(): | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is all fine, but needs to be tested.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! I’ll add additional tests to cover this case.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added tests to cover both manual positioning and layout-managed cases. Let me know if anything else should be tested.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd prefer an actual test that the positions match after layout is applied.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok, I'll add it
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added a test that explicitly checks that the twin and parent positions |
||
| twin._set_position(self.get_position(original=True), which="original") | ||
| twin._set_position(self.get_position(original=False), which="active") | ||
|
|
||
| return twin | ||
|
|
||
| def twinx(self, axes_class=None, **kwargs): | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -477,6 +477,42 @@ def test_twin_inherit_autoscale_setting(): | |
| assert not ax_y_off.get_autoscaley_on() | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("twin", ("x", "y")) | ||
| def test_twin_respects_position_after_set_position(twin): | ||
| fig, ax = plt.subplots() | ||
|
|
||
| ax.set_position([0.2, 0.2, 0.5, 0.5]) | ||
| ax2 = getattr(ax, f"twin{twin}")() | ||
|
|
||
| assert_allclose(ax.get_position(original=True).bounds, | ||
| ax2.get_position(original=True).bounds) | ||
|
|
||
| assert_allclose(ax.get_position(original=False).bounds, | ||
| ax2.get_position(original=False).bounds) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("twin", ("x", "y")) | ||
| def test_twin_keeps_layout_participation_for_layout_managed_axes(twin): | ||
| fig, ax = plt.subplots() | ||
|
|
||
| ax2 = getattr(ax, f"twin{twin}")() | ||
|
|
||
| assert ax.get_in_layout() | ||
| assert ax2.get_in_layout() | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("twin", ("x", "y")) | ||
| def test_twin_stays_aligned_after_constrained_layout(twin): | ||
| fig, ax = plt.subplots(constrained_layout=True) | ||
|
|
||
| ax.set_position([0.2, 0.2, 0.5, 0.5]) | ||
| ax2 = getattr(ax, f"twin{twin}")() | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you need to set the position like in the above test in order to test that this is working. Also please test with constrained layout. tight layout is mildly discouraged.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated the tests to set the position explicitly and added a constrained_layout case. Let me know if anything else is needed. |
||
|
|
||
| fig.canvas.draw() | ||
|
|
||
| assert_allclose(ax.get_position().bounds, ax2.get_position().bounds) | ||
|
|
||
|
|
||
| def test_inverted_cla(): | ||
| # GitHub PR #5450. Setting autoscale should reset | ||
| # axes to be non-inverted. | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.