Fix: improve log-scale error message wording#31449
Merged
timhoffm merged 2 commits intomatplotlib:mainfrom Apr 4, 2026
Merged
Conversation
rcomer
approved these changes
Apr 4, 2026
Member
rcomer
left a comment
There was a problem hiding this comment.
Thanks @cbrethick
Note for second reviewer: this is the second option from #31337 (comment)
timhoffm
approved these changes
Apr 4, 2026
Member
|
Thanks @cbrethick |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR improves the wording of the error message raised when attempting to apply a log scale to data that contains no positive values.
The previous message:
"Data has no positive values, and therefore cannot be log-scaled."
has been updated to:
"Data cannot be log-scaled because all values are <= 0."
This change makes the message clearer and more direct for users.
Closes #31337
AI Disclosure
I used AI assistance to better understand the contribution steps and structure of the pull request. The actual code change is simple and written by me.
PR checklist