lib/matplotlib/tests/test_inset.py: Fix tolerance on aarch64#31465
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Apr 21, 2026
Merged
lib/matplotlib/tests/test_inset.py: Fix tolerance on aarch64#31465QuLogic merged 1 commit intomatplotlib:mainfrom
QuLogic merged 1 commit intomatplotlib:mainfrom
Conversation
I tried to run the test suite on a aarch64 linux system and it failed due to test_zoom_inset_connector_styles exceeding the tolerance. The test is already checking the platform to increase the tolerance on aarch64 but the check is failing as on this system, ``platform.machine()`` is returning ``aarch64`` not ``arm64``. I've checked on several distributions and it seems consistent. So, update the check to match both ``arm64`` and ``aarch64``. Signed-off-by: Arnaud Patard <[email protected]>
timhoffm
approved these changes
Apr 15, 2026
QuLogic
approved these changes
Apr 21, 2026
Member
|
Thanks @apatard! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to run the test suite on a aarch64 linux system and it failed due to test_zoom_inset_connector_styles exceeding the tolerance. The test is already checking the platform to increase the tolerance on aarch64 but the check is failing as on this system,
platform.machine()is returningaarch64notarm64.I've checked on several distributions and it seems consistent.
So, update the check to match both
arm64andaarch64.