Fixed: specified exception type in cbook.py#31489
Merged
QuLogic merged 2 commits intomatplotlib:mainfrom Apr 17, 2026
Merged
Conversation
…xception with except(TypeError, ValueError) as the fixme comment addressed
timhoffm
approved these changes
Apr 12, 2026
Member
timhoffm
left a comment
There was a problem hiding this comment.
While I'm not a aware of an input that raises ValueError, those two are the only ones that semantically would make sense. Everything else should not be silently dropped so this makes sense.
QuLogic
approved these changes
Apr 17, 2026
Member
|
Thanks @Jaylon0418! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Solved the Fixme comment in cbook.py, for a more specified exception type. Replaced except Exception with except(TypeError, ValueError). The change is made based on how np.isinfinite() works.
AI Disclosure
I used AI for finding the problem, but wrote it by hand(literally one line:)
PR checklist