Make Animation._repr_html_ more useful by default#31510
Open
QuLogic wants to merge 1 commit intomatplotlib:mainfrom
Open
Make Animation._repr_html_ more useful by default#31510QuLogic wants to merge 1 commit intomatplotlib:mainfrom
QuLogic wants to merge 1 commit intomatplotlib:mainfrom
Conversation
cfeabab to
55e23db
Compare
Member
|
I like the idea. |
While `Animation` does define `_repr_html_`, it does nothing by default since `animation.html` is 'none'. The 'html5' option is the best, but it requires FFmpeg to be installed. So introduce a new 'auto' option that picks either one depending on what's available, and make it the default.
55e23db to
690f7d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
While
Animationdoes define_repr_html_, it does nothing by default sinceanimation.htmlis 'none'. The 'html5' option is the best, but it requires FFmpeg to be installed. So introduce a new 'auto' option that picks either one depending on what's available, and make it the default.This still needs some docs/tests, if we are okay with this approach.
AI Disclosure
None
PR checklist