Add suggestions to more lookup errors#31514
Merged
story645 merged 7 commits intomatplotlib:mainfrom Apr 21, 2026
Merged
Conversation
timhoffm
reviewed
Apr 17, 2026
efd3c77 to
d75015c
Compare
tacaswell
approved these changes
Apr 17, 2026
ksunden
approved these changes
Apr 17, 2026
timhoffm
reviewed
Apr 17, 2026
d75015c to
0cd7444
Compare
timhoffm
reviewed
Apr 18, 2026
No need for 'one of' if there's only one option, add a colon to match the syntax of Python's own suggestion message, and remove the trailing space if there's no suggestion.
The only usage was removed in 8cde5a8.
…cked This also means that the former now gains suggestions.
0cd7444 to
e47adc9
Compare
tacaswell
approved these changes
Apr 21, 2026
Member
tacaswell
left a comment
There was a problem hiding this comment.
This is significantly more extensive that the first time I looked at this so re-approving.
timhoffm
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This is an extension of #30001 to all the other registries, namely
ColorSequenceRegistry,ProjectionRegistry,MovieWriterRegistry,Colorizer, andCallbackRegistryinitialized with restrictedsignals, plus everything else that callscheck_in_listwith a list of strings. See the tests for examples.There are some additional tweaks to wording and such; see the individual commits for details.
AI Disclosure
None
PR checklist