Fix legend settings not preserved when regenerating in Qt figure options#31526
Closed
Jah-yee wants to merge 1 commit intomatplotlib:mainfrom
Closed
Fix legend settings not preserved when regenerating in Qt figure options#31526Jah-yee wants to merge 1 commit intomatplotlib:mainfrom
Jah-yee wants to merge 1 commit intomatplotlib:mainfrom
Conversation
When '(Re)-generate automatic legend' is checked in the Figure Options dialog, the regenerated legend previously only preserved 'ncols' and 'draggable' settings. Other important legend properties like 'bbox_to_anchor', 'loc', 'mode', and 'borderaxespad' were discarded. Now the code captures these additional properties from the existing legend (if present) and passes them to axes.legend(), preserving the user's intended legend appearance. Fixes matplotlib#17775
Member
|
This account is opening a lot of PRs in a short space of time so I assume they are automated. Closing the PR and blocking the account for a week per our policy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day
When '(Re)-generate automatic legend' is checked in the Figure Options dialog, the regenerated legend previously only preserved 'ncols' and 'draggable' settings. Other important legend properties like 'bbox_to_anchor', 'loc', 'mode', and 'borderaxespad' were discarded.
This fix captures these additional properties from the existing legend (if present) and passes them to
axes.legend(), preserving the user's intended legend appearance.Before (only ncols preserved):
After (all key properties preserved):
Testing:
ncols,loc,mode,borderaxespad, andbbox_to_anchorare all correctly preserved when regenerating a legend withbbox_to_anchor=(0, 1.02, 1, 0.2), loc='lower left', mode='expand', borderaxespad=0, ncol=3bbox_to_anchorormodeset still work correctlyFixes #17775
Thank you for your attention. If there are any issues or suggestions, please leave a comment and I will address them promptly.
Warmly,
RoomWithOutRoof