FIX: Inverted PyErr_Occurred check in enum type caster (_enums.h)#31556
Merged
ksunden merged 1 commit intomatplotlib:mainfrom Apr 23, 2026
Merged
FIX: Inverted PyErr_Occurred check in enum type caster (_enums.h)#31556ksunden merged 1 commit intomatplotlib:mainfrom
ksunden merged 1 commit intomatplotlib:mainfrom
Conversation
QuLogic
approved these changes
Apr 23, 2026
story645
reviewed
Apr 23, 2026
| value = decltype(value)(ival); \ | ||
| Py_DECREF(tmp); \ | ||
| return !(ival == -1 && !PyErr_Occurred()); \ | ||
| return !(ival == -1 && PyErr_Occurred()); \ |
Member
There was a problem hiding this comment.
Kinda think return (ival !=-1 || !PyErr_Occurred()); is more readable - is there a reason we can't do this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Fix an inverted error-check in the pybind11 enum type caster in src/_enums.h.
PyLong_AsLongsignals failure by returning -1 and setting a Python exception. The correct way to check for failure should be:return !(ival == -1 && PyErr_Occurred());Part of #31424
this is my first PR here; I just wanted to get the flow down of contributing here before making any larger changes :)
AI Disclosure
I used Claude Code to help understand the codebase. The fix itself is a one-character change I applied.
PR checklist