DOC: clarify source of Cn colors - #32049
Conversation
|
Thank you for opening your first PR into Matplotlib! If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process. You can also join us on discourse chat for real-time discussion. For details on testing, writing docs, and our review process, please see the developer guide. We strive to be a welcoming and open project. Please follow our Code of Conduct. |
| | into the default property cycle. +--------------------------------------+ | ||
| | | :rc:`axes.prop_cycle` | |
There was a problem hiding this comment.
I think the right way forward is
| | into the default property cycle. +--------------------------------------+ | |
| | | :rc:`axes.prop_cycle` | | |
| | into the default property cycle | | | |
| | (:rc:`axes.prop_cycle`). | | |
leaving the note unchanged.
Combined with #32071.
There was a problem hiding this comment.
Thanks! I’ve applied the suggested layout, keeping axes.prop_cycle in the description column while leaving the note unchanged. I also retained the blank separator required before the note directive so the table parses correctly.
|
Hi @timhoffm , I’ve addressed your feedback and all checks pass. Could you please take another look when convenient? |
|
Thanks @sahilmathur254! |
|
@meeseeksdev backport to v3.11.x |
…049-on-v3.11.x Backport PR #32049 on branch v3.11.x (DOC: clarify source of Cn colors)
* DOC: clarify source of Cn colors * DOC: clarify source of Cn colors * Update galleries/users_explain/colors/colors.py --------- Co-authored-by: Tim Hoffmann <[email protected]>
PR summary
Clarify that
Cncolors are resolved from the globalrcParams['axes.prop_cycle'], not an Axes-local cycle configured withAxes.set_prop_cycle.The existing phrase “default property cycle” was ambiguous because an Axes can have its own property cycle. This expands the existing note in the Color formats table.
Closes #32004
AI Disclosure
I used an AI-assisted coding tool to help draft the documentation wording and PR description. I reviewed the final diff and validation evidence and take responsibility for the contribution.
PR checklist