Reduce API surface of internal dataclasses - #32291
Merged
Merged
Conversation
iccir
approved these changes
Sep 4, 2026
iccir
left a comment
Contributor
There was a problem hiding this comment.
Should we take this opportunity to standardize on @dataclass with an import vs @dataclasses.dataclass?
In almost all cases, these are not modified, so they can be marked `frozen` and with `slots` to make them immutable. We can also drop the `__eq__` method for _really_ internal things that are just data.
QuLogic
force-pushed
the
dataclass-slots
branch
from
September 4, 2026 19:53
aba2d17 to
97bb360
Compare
timhoffm
approved these changes
Sep 4, 2026
timhoffm
left a comment
Member
There was a problem hiding this comment.
+/-0 on standardizing the decorator
Contributor
We can always do it in the future if we want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
In almost all cases, these are not modified, so they can be marked
frozenand withslotsto make them immutable. We can also drop the__eq__method for really internal things that are just data.Theoretically, there is some memory savings, but I could not see much of it (possibly I just didn't test the right thing to trigger it.) With
memray, I did see fewer allocations, though overall about the same memory usage.AI Disclosure
None
PR quality check