Improve error message for boxplot_stats function, by printing dimensions. - #32305
Conversation
|
Thank you for opening your first PR into Matplotlib! If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process. You can also join us on discourse chat for real-time discussion. For details on testing, writing docs, and our review process, please see the developer guide. We strive to be a welcoming and open project. Please follow our Code of Conduct. |
a0fae4d to
dc75afb
Compare
|
Note that you need to use "Closes #X" explicitly in the PR in order to link the corresponding issue. See Linking a pull request to an issue using a keyword. |
iccir
left a comment
There was a problem hiding this comment.
Looks good to me. I'll let the second reviewer decide if any of the formatting should be changed.
|
@iccir This doesn't close the linked issue. |
jklymak
left a comment
There was a problem hiding this comment.
I rephrase this lot directly if we are making a change. "The number of labels ({len(labels)}) must match the number of columns {ncols}." "Compatible with" is vague in this case where there isn't more than one way they are compatible.
dc75afb to
0f2ebb6
Compare
|
@jklymak Updated. |
|
@meeseeksdev backport to v3.11.x |
…305-on-v3.11.x Backport PR #32305 on branch v3.11.x (Improve error message for boxplot_stats function, by printing dimensions.)
PR summary
This edits the error message raised by
boxplot_statsfor incompatible dimensions to print those dimensions. This is useful for debugging. Related issue: #32304.AI Disclosure
No AI used.
PR quality check