Don't force any diagnostics to be errors in bundled Harfbuzz - #32324
Conversation
We can't be certain that compilers won't add or change which diagnostics work for a flag. So disable Harfbuzz's pragmas that turn diagnostics into errors, as this is really something that only upstream should worry about.
41862db to
292dc1c
Compare
iccir
left a comment
There was a problem hiding this comment.
Approved assuming I understand this correctly:
We can't directly add HB_NO_PRAGMA_GCC_DIAGNOSTIC_ERROR to meson.build since it's a subproject, so we add a diff to patch it when first downloaded.
Indeed, though we should have been able to set |
|
@QuLogic There is a contourpy wheel for pyodide python 3.15 available on scientific-python-nightly-wheels as of just now. |
|
Thanks @ianthomas23! It looks like we still need kiwisolver as well (I tried to set it up, but hitting some testing issues nucleic/kiwi#245) I would not wait for that for this PR at least, as the workflow was broken before, so it should be fine for now to continue being broken. |
|
Merging over the wasm wheel being broken per Elliott. |
…324-on-v3.11.x Backport PR #32324 on branch v3.11.x (Don't force any diagnostics to be errors in bundled Harfbuzz)
PR summary
We can't be certain that compilers won't add or change which diagnostics work for a flag. So disable Harfbuzz's pragmas that turn diagnostics into errors, as this is really something that only upstream should worry about.
This partially fixes the WASM build for Python 3.15, cf. harfbuzz/harfbuzz#6059 Though we should also update HarfBuzz too, we want to avoid this breaking for future compilers if we haven't yet done so.
AI Disclosure
None
PR quality check