Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reset selector state when callbacks raise #32332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LouisDeconinck wants to merge 1 commit into from
+20 −4
Closed

Reset selector state when callbacks raise #32332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions lib/matplotlib/tests/test_widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,20 @@ def test_span_selector_onselect(ax, interactive):
onselect.assert_called_once()


def test_selector_state_is_reset_when_callback_raises(ax):
onselect = mock.Mock(side_effect=[RuntimeError, None])
tool = widgets.SpanSelector(ax, onselect, 'horizontal')

with pytest.raises(RuntimeError):
click_and_drag(tool, start=(100, 100), end=(150, 100))

assert tool._eventpress is None
assert tool._eventrelease is None

click_and_drag(tool, start=(100, 100), end=(150, 100))
assert tool._selection_completed


@pytest.mark.parametrize('ignore_event_outside', [True, False])
def test_span_selector_ignore_outside(ax, ignore_event_outside):
onselect = mock.Mock(spec=noop, return_value=None)
Expand Down
10 changes: 6 additions & 4 deletions lib/matplotlib/widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2502,10 +2502,12 @@ def release(self, event):
if not self.ignore(event) and self._eventpress:
event = self._clean_event(event)
self._eventrelease = event
self._release(event)
self._eventpress = None
self._eventrelease = None
self._state.discard('move')
try:
self._release(event)
finally:
self._eventpress = None
self._eventrelease = None
self._state.discard('move')
return True
return False

Expand Down
Loading