Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TYP: PieContainer does not inherit from Container - #32344

Merged
timhoffm merged 1 commit into
matplotlib:mainfrom
rcomer:stub-pie
Sep 12, 2026
Merged

TYP: PieContainer does not inherit from Container#32344
timhoffm merged 1 commit into
matplotlib:mainfrom
rcomer:stub-pie

Conversation

@rcomer

@rcomer rcomer commented Sep 12, 2026

Copy link
Copy Markdown
Member

PR summary

I'm surprised stubtest didn't catch this. PieContainer did inherit from Container when #30733 was first opened, but we dropped that in review.

AI Disclosure

None used

PR quality check

  • Use an expressive title, e.g. "Fix title font property precedence"
  • [n/a] New and changed code is tested
  • [n/a] Plotting related features are demonstrated in an example
  • [n/a] New features and API changes have release notes
  • [n/a] Documentation complies with general and docstring guidelines

@rcomer

rcomer commented Sep 12, 2026

Copy link
Copy Markdown
Member Author

Huh. stubtest passed locally but failed here. Do you have to clear something out to get a proper check?

Edit: maybe it was because I had not committed the change before the local check.

@rcomer
rcomer marked this pull request as draft September 12, 2026 08:34
@rcomer
rcomer marked this pull request as ready for review September 12, 2026 10:23
@timhoffm timhoffm added this to the v3.11.3 milestone Sep 12, 2026
@timhoffm
timhoffm merged commit a99bc61 into matplotlib:main Sep 12, 2026
40 of 41 checks passed
@lumberbot-app

lumberbot-app Bot commented Sep 12, 2026

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:
They assume that the base project is the Git remote upstream and your fork is origin.

  1. Update backport branch.
git fetch upstream v3.11.x:v3.11.x
# or `git pull upstream v3.11.x` if you are on v3.11.x
  1. Create PR branch.
git switch -c auto-backport-of-pr-32344-on-v3.11.x v3.11.x
  1. Cherry pick the first parent branch of this PR on top of the older branch:
git cherry-pick -x -m1 a99bc61d82b76eab80509a57e39fa20a556d1985
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #32344: TYP: PieContainer does not inherit from Container'
  1. Push to a named branch:
git push --set-upstream origin auto-backport-of-pr-32344-on-v3.11.x
  1. Create a PR against branch v3.11.x, I would have named this PR:

Backport PR #32344 on branch v3.11.x (TYP: PieContainer does not inherit from Container)

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@rcomer
rcomer deleted the stub-pie branch September 12, 2026 13:31
rcomer pushed a commit to rcomer/matplotlib that referenced this pull request Sep 12, 2026
timhoffm added a commit that referenced this pull request Sep 13, 2026
Backport PR #32344: TYP: PieContainer does not inherit from Container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants