Simplify embedding webagg example now that WebSocket is widely supported - #32348
Open
takluyver wants to merge 2 commits into
Open
Simplify embedding webagg example now that WebSocket is widely supported#32348takluyver wants to merge 2 commits into
takluyver wants to merge 2 commits into
Conversation
Contributor
|
Relevant discussion: #32165 |
Contributor
Author
|
That sounds like people are converging on a policy to support browser versions going back 5 years, which would seemingly exclude the websocket relative URL part, but allow using I think there's a case that an example can assume newer browser versions than code shipped in matplotlib itself, and leave compatibility up to the developer using the example. But I'm not going to argue with this - if you'd like me to revert the relative URL part, just let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
All major browsers have supported websockets for over a decade; at this point I think examples should use it directly without a compatibility wrapper.
Perhaps a bit more controversial, websockets can use relative URLs since about 2024, which avoids the need to template the hostname into the HTML. I think it makes sense to simplify this, since keeping browsers up to date is both good advice and the default, not many people are likely to be using a two-year-old browser.
AI Disclosure
I have not used any AI.
PR quality check