Don't use unicode_literals in backend_qt4 #3358
Closed
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an alternative to matplotlib#3357. In short using unicode_lieterals with six.u does not work and results in TypeErrors in python 2. This fixes is by not using unicode_literals rather than getting rid of six.u
|
I strongly prefer the other one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #3357. In short using unicode_lieterals with
six.u does not work and results in TypeErrors in python 2. This fixes
is by not using unicode_literals rather than getting rid of six.u
An alternative to #3357
This seems to work too but I am less confident that it will not introduce other issues.