Thanks to visit codestin.com
Credit goes to github.com

Skip to content

make wx backends compatible with wxPython-Phoenix #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 23, 2015
Merged

make wx backends compatible with wxPython-Phoenix #3421

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
758f826
Update wx backend to be compatible with wxPython classic 2.8.12+ on P…
wernerfb Apr 23, 2015
91c4296
add import six as it is part of the standard imports
wernerfb Apr 24, 2015
ba2fce5
create a what's new entry
wernerfb Apr 25, 2015
ad6a712
improve text
wernerfb Apr 28, 2015
12cf540
improve text
wernerfb May 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve text
  • Loading branch information
@wernerfb
wernerfb committed Apr 28, 2015
commit ad6a7123558209565629853f7b309dfb2ac155cc
6 changes: 4 additions & 2 deletions doc/users/whats_new/updated_backend_wx.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@ The wx backend can now be used with both wxPython classic and
wxPython classic has to be at least version 2.8.12 and works on Python 2.x,
wxPython Phoenix needs a current snapshot and works on Python 2.7 and 3.4+.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"needs a current snapshot" <-- this phrase will not age well. I would consider taking it out, and just stating what versions of python it is intended for (which is entirely the point of the sentence). This version of matplotlib won't be released for a few more months, anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WeatherGod I still think this needs some kind of version specification for WX Phoenix. I don't know if it is likely that there will be an official release before the next Matplotlib release.

I would replace current with a date/month something like "As of April 2015 no official wxPhoenix release has been made but a recent snapshot should work ..." Followed by the python versions supported.


User code is responsible to set the wxPython version you want to use, see for
example the `examples\user_interfaces\embedding_in_wx2.py`.
If you have multiple versions of wxPython installed, then the user code is
responsible to set the wxPython version you want to use. How to do this is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"to set" --> "for setting". Nix "you want".

explained in the comment at the beginning of example the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"example the" --> "the example"

`examples\user_interfaces\embedding_in_wx2.py`.