Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow python 3 version of PyCXX #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2014
Merged

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Sep 16, 2014

setupext.py is hard-coded to not use an external version of PyCXX with python 3 (starting with line 831 in master), claiming that "There is no version of PyCXX in the wild that will work with Python 3.x". This is no longer the case, PyCXX is compatible with python 3.

@tacaswell tacaswell added this to the v1.4.x milestone Sep 10, 2014
@mdboom
Copy link
Member

mdboom commented Sep 10, 2014

No -- this comment is still correct. The upstream versions of PyCXX lack support for buffer objects. I submitted a patch years ago, and it still hasn't been incorporated. It also seems that the PyCXX sourcecode repository on Sourceforge is no gone without a forwarding address, so it's not clear if anyone is maintaining it anymore.

In any case, I'm closing this issue, since it is still the case that the matplotlib-shipped version of PyCXX must be used on Python 3. I should probably also open a new bug to consider whether we should take on maintainership (dare I say "fork") PyCXX at this point.

@mdboom mdboom closed this Sep 10, 2014
@toddrjen
Copy link
Contributor Author

Fair enough, although it is probably a good idea to update the comment to clarify the situation, since it is misleading.

@mdboom mdboom reopened this Sep 16, 2014
@mdboom
Copy link
Member

mdboom commented Sep 16, 2014

@toddrjen: How does the attached look to you?

@cimarronm
Copy link
Contributor

Seems to clarify it nicely

mdboom added a commit that referenced this pull request Sep 16, 2014
Allow python 3 version of PyCXX
@mdboom mdboom merged commit 0575dc5 into matplotlib:v1.4.x Sep 16, 2014
@mdboom mdboom deleted the clarify-pycxx branch March 3, 2015 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants