-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Left ventricle bull eye #3518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left ventricle bull eye #3518
Conversation
In this example we create the bull eye representation for the left ventricle according to the American Heart Association (AHA)
Thanks! Could you also provide some synthetic data in-line and have it actually make a plot? The figure will be automatically saved and included in the documentation. |
There are a bunch of extraneous blank spaces. I would also reduce the scope of the function by having it focus strictly on the small task of plotting. Move all of the colobar, plt.show(), figure handling out of the function. I also don't like to encourage optional returns. Either always return it, or not. |
Following your suggestions, I made some changes. Let me know if it is ok for you. |
Hi, please let me know if I need to do something else. |
import matplotlib.pyplot as plt | ||
|
||
|
||
def bulleye_plot(data, ax, vlim=None, segBold=[]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make ax
the first argument?
import matplotlib.pyplot as plt | ||
|
||
|
||
def bullseye_plot(ax, data, vlim=None, segBold=[]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be modified to take in a colormap specifier as in input.
To control the color map limits, use the If you want to color the over/under values differently you can use the |
Your particular problem will be result using the vlim kwarg as tacaswell said in a previous reply. About the option to change the color map, I'll take a look. |
I think this needs the option to change colormap otherwise 👍 from me |
Please let me know if I can help you with anything else. |
@curiale Thanks. Your work is now part of the public docs: http://matplotlib.org/devdocs/examples/pylab_examples/leftventricle_bulleye.html |
In this example we create the bull eye representation for the left ventricle according to the American Heart Association (AHA)