BUG : fix cla behavior with twinx #3634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will affect all shared axes, not just the twinned version, correct? |
|
Yes, but hopefully grabbing the pre-clearing visibility of the patch and axis objects will make this ok. |
|
This looks OK as a minimal bug fix. It's hard to read that very long |
Closes matplotlib#3633 Added more special-case logic for twined axes.
|
@efiring added test and fixed a transposition bug in the original bug fix. It's all collapsed down to one commit and force-pushed. |
efiring
added a commit
that referenced
this pull request
Jan 27, 2015
BUG : fix cla behavior with twinx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3633
Added more special-case logic for twined axes.
This needs a test.
I am not a huge fan of this solution, but it might be the minimal change.