backend_pgf: \pgftext now requires \color inside argument (fix #3779) [backport to 1.4.x] #3780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -638,7 +638,7 @@ def draw_text(self, gc, x, y, s, prop, angle, ismath=False, mtext=None): | |||
| # prepare string for tex | |||
| s = common_texification(s) | |||
| prop_cmds = _font_properties_str(prop) | |||
| s = r"{%s %s}" % (prop_cmds, s) | |||
There was a problem hiding this comment.
I know almost nothing about pgf, but dropping the {} smells funny....
There was a problem hiding this comment.
It was redundant because in the end s is embedded into \pgftext[%s]{%s}.
|
Looks fine to me. Should we add a pgf test with coloured text. I know travis can't run it but it might still be useful? |
tacaswell
added a commit
that referenced
this pull request
Nov 11, 2014
BUG : backend_pgf: \pgftext now requires \color inside argument (fix #3779) [backport to 1.4.x]
tacaswell
added a commit
that referenced
this pull request
Nov 11, 2014
BUG : backend_pgf: \pgftext now requires \color inside argument (fix #3779) [backport to 1.4.x]
|
cherry-picked as c31ffe8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On systems using TeX Live 2014
\pgftextdoesn't handle text color the same way as before. Add\colorcommand inside the text argument to adapt to this new behaviour.