@briantoby can you confirm that these fix your issues?

@wernerfb does this conflict with anything in your PR?

I am not about to contradict Robin:), if it conflicts with my changes I
will have to deal with them. I had a quick look at the code and I don't think this is something I touched.

Werner

This helps, but still has problems, at least as I tested it. When I tried this by copying the changed file into matplotlib 1.4.2, I still had problems with the zoom button. As soon as I start dragging the mouse, the plot scaling changes so that while dragging the mouse, I only see the upper left-hand corner of the plot. As soon as I release the mouse, the plot updates to show the region that I zoomed in upon.

FWIW, I found that commenting out the odc.Clear() call in draw_rubberband():

def draw_rubberband(self, event, x0, y0, x1, y1):
    ...
    #odc.Clear()
    ...

prevents the change in scaling, but then the zoom becomes an opaque box overlaid on the plot.

Before zoom:

During drag:

@briantoby, are you on a system with a Retina display? I don't have one to experiment with, but it sounds like it might be related to that. Which version of wxPython are you using?

Retina: yes (10.9.5 FWIW)

Also, yes, the problem goes away, when I use an external monitor connected to this laptop.

wxpython: 3.0.0.0

Is there anything I can help test?

I'm waiting on an answer to questions I asked in wx-dev to see if there is some way to use the wx.Overlay without the Retina issue, otherwise I'll come up with a different implementation for draw_rubberband that may not look as nice, but won't leave mouse trails behind. At that point some testing will be helpful.

@RobinD42 Any eta on this? The target date for 1.4.3 is Feb 1 so we need to get an RC out in the next few weeks.

Is it worth merging this as-is and worrying about retina support later?

@tacaswell, I havn't heard back about my questions related to wx.Overlay yet, I'll try again. In the meantime I think that an all-but-retina fix is probably better than the current implementation so I think it's worth merging.

I've had an idea that may work around the issue on retina displays, but its going to take some more work to be sure. I'll keep the idea simmering and will try to get back to it soon.