pgf can not write to BytesIO [back port to 1.4.x]
#3982
Conversation
|
Support pgf code output to non-file/in-memory streams or anything else that has a |
|
As mentioned in #3979, we then get the following error: Traceback (most recent call last):
File "/home/afrl/anaconda/lib/python2.7/site-packages/tornado/web.py", line 1332, in _execute
result = method(*self.path_args, **self.path_kwargs)
File "/home/afrl/workspace/matplotlib/lib/matplotlib/backends/backend_webagg.py", line 207, in get
manager.canvas.print_figure(buff, format=fmt)
File "/home/afrl/workspace/matplotlib/lib/matplotlib/backend_bases.py", line 2216, in print_figure
**kwargs)
File "/home/afrl/workspace/matplotlib/lib/matplotlib/backends/backend_pgf.py", line 843, in print_pgf
self._print_pgf_to_fh(fname_or_fh, *args, **kwargs)
File "/home/afrl/workspace/matplotlib/lib/matplotlib/backends/backend_pgf.py", line 805, in _print_pgf_to_fh
fh.write(header_text)
TypeError: 'unicode' does not have the buffer interface |
|
I cannot reproduce that error when saving to a |
|
Seems like a py2 / py3 problem, but for me it's the other way around. Here, python2 works as expected, with python3 I'm getting Is this a common problem when porting from 2to3? |
|
We should not have Or I am very confused by what you meant 🐑 |
|
Oh sorry, I just meant the general porting/transition process from python 2 to python 3, I didn't intend to refer to the |
|
I think this will do it (I get a diff --git a/lib/matplotlib/backends/backend_pgf.py b/lib/matplotlib/backends/backend_pgf.py
index 915ad59..d16bd13 100644
--- a/lib/matplotlib/backends/backend_pgf.py
+++ b/lib/matplotlib/backends/backend_pgf.py
@@ -138,8 +138,8 @@ def common_texification(text):
def writeln(fh, line):
# every line of a file included with \input must be terminated with %
# if not, latex will create additional vertical spaces for some reason
- fh.write(line)
- fh.write("%\n")
+ fh.write(line.encode('utf-8'))
+ fh.write("%\n".encode('utf-8'))
def _font_properties_str(prop):
@@ -801,10 +801,10 @@ class FigureCanvasPgf(FigureCanvasBase):
w, h = self.figure.get_figwidth(), self.figure.get_figheight()
dpi = self.figure.get_dpi()
def _font_properties_str(prop):
@@ -801,10 +801,10 @@ class FigureCanvasPgf(FigureCanvasBase):
w, h = self.figure.get_figwidth(), self.figure.get_figheight()
- # create pgfpicture environment and write the pgf code
- fh.write(header_text)
- fh.write(header_info_preamble)
- fh.write("\n")
+ # create pgfpicture environment and write the pgf code
+ fh.write(header_text.encode('utf-8'))
+ fh.write(header_info_preamble.encode('utf-8'))
+ fh.write("\n".encode('utf-8'))
writeln(fh, r"\begingroup")
writeln(fh, r"\makeatletter")
writeln(fh, r"\begin{pgfpicture}") |
|
Recently came across something similar at work, we added a helper function def encoding_writer(fh, input_str, encoding='utf-8'):
fh.write(input_str.encode(encoding))which at least seems less obnoxious to use that throwing |
|
You're obnoxious 😄 |
|
I installed |
|
New diff that gets me to the same point: diff --git a/lib/matplotlib/backends/backend_pgf.py b/lib/matplotlib/backends/backend_pgf.py
index 915ad59..3bec6dc 100644
--- a/lib/matplotlib/backends/backend_pgf.py
+++ b/lib/matplotlib/backends/backend_pgf.py
@@ -135,11 +135,15 @@ def common_texification(text):
return "".join(parts)
+def encoding_writer(fh, input_str, encoding='utf-8'):
+ fh.write(input_str.encode(encoding))
+
+
def writeln(fh, line):
# every line of a file included with \input must be terminated with %
# if not, latex will create additional vertical spaces for some reason
- fh.write(line)
- fh.write("%\n")
+ encoding_writer(fh, line)
+ encoding_writer(fh, "%\n")
def _font_properties_str(prop):
@@ -801,10 +805,10 @@ class FigureCanvasPgf(FigureCanvasBase):
w, h = self.figure.get_figwidth(), self.figure.get_figheight()
dpi = self.figure.get_dpi()
- # create pgfpicture environment and write the pgf code
- fh.write(header_text)
- fh.write(header_info_preamble)
- fh.write("\n")
+ # create pgfpicture environment and write the pgf code
+ encoding_writer(fh, header_text)
+ encoding_writer(fh, header_info_preamble)
+ encoding_writer(fh, "\n")
writeln(fh, r"\begingroup")
writeln(fh, r"\makeatletter")
writeln(fh, r"\begin{pgfpicture}") |
|
Ah ok, the stream output path is missing an output encoder. When saving to a file, the file is opened using |
|
Solution now tested with python2 and python3. Added a second commit that adds pgf to the list of output options in webagg_core again. |
|
Tested on Python3 with webagg, 👍 |
BytesIOBytesIO [back port to 1.4.x]
pgf can not write to `BytesIO` [back port to 1.4.x]
Discovered as part of #3981