Revert "Merge pull request #3681 from jbmohler/use_fast_from_codes_and_v... #4007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is wrong with me?
|
attn @jbmohler |
|
Don't merge this yet, having issues make it fail if I re-introduce the changes, may need to tweak the test. |
example from PR matplotlib#3998
ef825bf to
9e68161
Compare
|
Managed to track down the actual problem, so this PR can be ignored, fully superseded by #4008 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...erts"
This reverts commit c299457, reversing
changes made to 38d69b0.
This is a fix for #3998, but there is an underlying issue with
_fast_from_codes_and_vertswhich should be sorted out.This also adds a test. After this is merged I will put in a new PR with 91725d8 re-based onto the new master.