Codestin Search App

blink1073 · 2015-01-19T17:22:15Z

get_children is used by hitlist, and should match the ordering used by draw. Also consolidates so the order is only established in one place, and draw calls get_children to get the proper ordering.

blink1073 · 2015-01-19T17:37:42Z

I would recommend calling get_children in draw, and then removing artists if they are not going to be rendered, so they stay in sync.

blink1073 · 2015-01-19T17:39:35Z

On a side note, I should have started hacking on matplotlib at least three years ago, this is a lot of fun.

tacaswell · 2015-01-19T20:03:03Z

Looks good to me. This should probably be documented in https://github.com/matplotlib/matplotlib/tree/master/doc/api/api_changes .

👍 on re-using this in draw, the more we can reduce the size of the library the better.

blink1073 · 2015-01-20T01:36:10Z

Done on both fronts.

tacaswell · 2015-01-20T03:03:04Z

This broke all of the builds


======================================================================
FAIL: matplotlib.tests.test_collections.test_polycollection_close.test
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages/matplotlib-1.5.dev1-py3.4-linux-x86_64.egg/matplotlib/testing/decorators.py", line 51, in failer
    result = f(*args, **kwargs)
  File "/home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages/matplotlib-1.5.dev1-py3.4-linux-x86_64.egg/matplotlib/testing/decorators.py", line 196, in do_test
    '(RMS %(rms).3f)'%err)
matplotlib.testing.noseclasses.ImageComparisonFailure: images not close: /home/travis/build/matplotlib/tmp_test_dir/result_images/test_collections/polycollection_close.png vs. /home/travis/build/matplotlib/tmp_test_dir/result_images/test_collections/polycollection_close-expected.png (RMS 16.460)

======================================================================
FAIL: matplotlib.tests.test_table.test_label_colours.test
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages/matplotlib-1.5.dev1-py3.4-linux-x86_64.egg/matplotlib/testing/decorators.py", line 51, in failer
    result = f(*args, **kwargs)
  File "/home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages/matplotlib-1.5.dev1-py3.4-linux-x86_64.egg/matplotlib/testing/decorators.py", line 196, in do_test
    '(RMS %(rms).3f)'%err)
matplotlib.testing.noseclasses.ImageComparisonFailure: images not close: /home/travis/build/matplotlib/tmp_test_dir/result_images/test_table/table_labels.png vs. /home/travis/build/matplotlib/tmp_test_dir/result_images/test_table/table_labels-expected.png (RMS 21.070)

======================================================================
FAIL: mpl_toolkits.tests.test_mplot3d.test_mixedsubplots.test
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages/matplotlib-1.5.dev1-py3.4-linux-x86_64.egg/matplotlib/testing/decorators.py", line 51, in failer
    result = f(*args, **kwargs)
  File "/home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages/matplotlib-1.5.dev1-py3.4-linux-x86_64.egg/matplotlib/testing/decorators.py", line 196, in do_test
    '(RMS %(rms).3f)'%err)
matplotlib.testing.noseclasses.ImageComparisonFailure: images not close: /home/travis/build/matplotlib/tmp_test_dir/result_images/test_mplot3d/mixedsubplot.png vs. /home/travis/build/matplotlib/tmp_test_dir/result_images/test_mplot3d/mixedsubplot-expected.png (RMS 13.760)

======================================================================
FAIL: mpl_toolkits.tests.test_mplot3d.test_mixedsubplots.test
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages/matplotlib-1.5.dev1-py3.4-linux-x86_64.egg/matplotlib/testing/decorators.py", line 51, in failer
    result = f(*args, **kwargs)
  File "/home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages/matplotlib-1.5.dev1-py3.4-linux-x86_64.egg/matplotlib/testing/decorators.py", line 196, in do_test
    '(RMS %(rms).3f)'%err)
matplotlib.testing.noseclasses.ImageComparisonFailure: images not close: /home/travis/build/matplotlib/tmp_test_dir/result_images/test_mplot3d/mixedsubplot_pdf.png vs. /home/travis/build/matplotlib/tmp_test_dir/result_images/test_mplot3d/mixedsubplot-expected_pdf.png (RMS 20.466)

blink1073 · 2015-01-20T03:22:52Z

Hopefully that does it.

tacaswell · 2015-01-20T03:25:36Z

This is a change to a core-enough part of the library this needs to be looked at by at least a few more people.

cc @mdboom @efiring @WeatherGod @pelson

blink1073 · 2015-01-20T03:26:28Z

Ha! Drawing is a core part of the library?

blink1073 · 2015-01-20T03:26:56Z

(tongue in cheek of course)

blink1073 · 2015-01-20T03:35:34Z

Passes now (waiting on build docs, holy smokes it takes a while to build those suckers).

efiring · 2015-05-14T06:54:26Z

I like the idea of fixing the order in get_children(). Looking at this brings the following thought: it seems a little odd to have to get all of the children and then throw away half of them because they are special cases--the patch, the frame, etc. Would it make sense to let get_children() take an argument to determine whether it returns all children, or just the ones in a category? There seem to be two major categories: the artists directly associated with the Axes, and those that can be considered data. I haven't looked closely, so chances are I am missing something.

tacaswell · 2015-05-15T13:31:49Z

@efiring I agree that makes sense, but want to punt on that to get this merged ASAP (so it gets some usage by the brave souls running master before we tag) .

It might be useful to let get_children (or a slightly differently named sibling method) take a function as an input so you could use it as a filter ex get_children(filter=lambda x : isinstance(x, Line2D)).

Explicitly tagging Artists as being 'infrastructure' or 'data' (or whatever) is probably something we should think about in the coming Great Artist Refactor of '15.

WeatherGod · 2015-05-15T13:40:37Z

This sort of touches on a similar theme I raised in a PR (I don't have the
number on me), where I wanted to be able to select the order in which
elements of a collection are drawn. I did it by keeping a private attribute
that can be supplied to numpy arrays (so it can be indexes, slice or
boolean array). Maybe it could be generalizable?

On Fri, May 15, 2015 at 9:31 AM, Thomas A Caswell [email protected]
wrote:

@efiring https://github.com/efiring I agree that makes sense, but want
to punt on that to get this merged ASAP (so it gets some usage by the brave
souls running master before we tag) .

It might be useful to let get_children (or a slightly differently named
sibling method) take a function as an input so you could use it as a filter
ex get_children(filter=lambda x : isinstance(x, Line2D)).

Explicitly tagging Artists as being 'infrastructure' or 'data' (or
whatever) is probably something we should think about in the coming Great
Artist Refactor of '15.

—
Reply to this email directly or view it on GitHub
#4014 (comment)
.

Fix Axes `get_children` order to match `draw` order

Fix get_children order to match draw order

b1db610

tacaswell added the status: needs review label Jan 19, 2015

tacaswell added this to the v1.5.x milestone Jan 19, 2015

blink1073 added 2 commits January 19, 2015 19:35

Add an api change document

a449d92

Change draw to pull from get_children

1bacd63

Handle visibility of the x and y axis

7ef11ab

blink1073 added 2 commits January 19, 2015 21:43

Guard against removing animated images

93b0679

Fix the animate image guard

84e8e0d

blink1073 changed the title ~~Fix Axes get_children Order to Match draw Order~~ Fix Axes get_children order to match draw order Jan 26, 2015

tacaswell mentioned this pull request Feb 16, 2015

MEP25 - Artist Manager Class Discussion #3424

Closed

tacaswell modified the milestones: proposed next point release, next point release Feb 19, 2015

efiring added a commit that referenced this pull request May 15, 2015

Merge pull request #4014 from blink1073/fix-axes-children-order

60eace2

Fix Axes `get_children` order to match `draw` order

efiring merged commit 60eace2 into matplotlib:master May 15, 2015

efiring removed the status: needs review label May 15, 2015

ianhi mentioned this pull request Dec 8, 2020

Why does setting imshow(animated=True) still show an image? #18985

Closed

Uh oh!

Conversation

blink1073 commented Jan 19, 2015

Uh oh!

blink1073 commented Jan 19, 2015

Uh oh!

blink1073 commented Jan 19, 2015

Uh oh!

tacaswell commented Jan 19, 2015

Uh oh!

blink1073 commented Jan 20, 2015

Uh oh!

tacaswell commented Jan 20, 2015

Uh oh!

blink1073 commented Jan 20, 2015

Uh oh!

tacaswell commented Jan 20, 2015

Uh oh!

blink1073 commented Jan 20, 2015

Uh oh!

blink1073 commented Jan 20, 2015

Uh oh!

blink1073 commented Jan 20, 2015

Uh oh!

efiring commented May 14, 2015

Uh oh!

tacaswell commented May 15, 2015

Uh oh!

WeatherGod commented May 15, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants