quiver: add orientation kwarg. Closes #3709 [backport to 1.4.x] #4025
Conversation
|
Maybe this could go into 1.4.x with the present default, and the default could be changed to "relative" in 1.5. The more I think about it, the more I tend to conclude that the present behavior would be unexpected by just about anyone. It hasn't been a problem only because people haven't been making many quiver plots with inverted axes. |
| @@ -74,6 +74,20 @@ def test_quiver_with_key(): | |||
| 'size': 'large'}) | |||
|
|
|||
|
|
|||
| @image_comparison(baseline_images=['quiver_orientation_test_image'], | |||
There was a problem hiding this comment.
Best remove any text from this test. It will make it more resilient to freetype changes.
There was a problem hiding this comment.
True, but it will also make it very difficult to interpret the plot if someone wants to understand the behavior it is testing.
|
I'm going to close this; it is not the right solution for v1.4.3. I will submit an alternative that will include the removal of the conditional from the draw method. I think this will fix #3817 as well as #4025 provided the |
The default behavior is unchanged, but there is a new kwarg, "orientation". The default is "absolute", in which arrow angles, whether specified directly or calculated from U and V, are CCW relative to the axis pointing to the right. If set to "relative", then arrow orientation follows the orientation of the x and y data axes; when an axis is inverted, the arrows are reflected about the perpendicular axis. One would use "relative" for displaying gradients, as in #3709.
I'm open to alternative suggestions for the kwarg name and/or values.